Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 592293003: IDL: Remove the CompareHow special case (Closed)

Created:
6 years, 3 months ago by Jens Widell
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Remove the CompareHow special case It's a special type used only for Range.compareBoundaryPoints()'s |how| argument, and all the bindings layer actually does is cast a 32-bit int to the Range::CompareHow C++ enumeration, without any checks. The spec's IDL has the argument's type as |unsigned short|. This doesn't change any behavior (the value checks were always in the C++ code, and still are), aligns our IDL files with the spec, and, most significantly, removes the special case from the code generator. BUG=413257 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -47 lines) Patch
M Source/bindings/scripts/v8_types.py View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 3 chunks +0 lines, -38 lines 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL
6 years, 3 months ago (2014-09-23 12:09:30 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-23 12:23:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592293003/1
6 years, 3 months ago (2014-09-23 12:26:03 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 14:11:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182498

Powered by Google App Engine
This is Rietveld 408576698