Send initializeChildFrame from RenderFrameProxy instead of WebLocalFrame (part 2)

Send initializeChildFrame from RenderFrameProxy rather than WebLocalFrame (part 2).

Move initializeChildFrame from RenderFrameImpl to RenderFrameProxy.  Replace RenderFrameImpl::OnSwapOut's call to setIsRemote with WebRemoteFrame::initializeFromFrame that was introduced in part 1 of this change (https://codereview.chromium.org/591413004/)

This will be followed by another CL that will remove setIsRemote on the blink side.

BUG=416102
Committed: https://crrev.com/05334c25134091e0bb662dd4793d63ed655b9b07
Cr-Commit-Position: refs/heads/master@{#296822}

[alexmos, 2014-09-25 18:32:30]

alexmos@chromium.org changed reviewers:
+ creis@chromium.org

[alexmos, 2014-09-25 20:13:54]

Charlie, could you please take a look?
Thanks!
Alex

[nasko, 2014-09-25 20:17:51]

nasko@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2014-09-25 20:17:52]

Just one drive-by comment.

https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
content/renderer/render_frame_impl.cc:1066: // Send initial drawing parameters
to the frame being rendered remotely.
nit: I'd put a comment that is more generic. Now it is just drawing, later on
might be more, which will make the comment stale.

[Charlie Reis, 2014-09-25 20:53:17]

Great!  LGTM with nit.

https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
File content/renderer/render_frame_proxy.h (right):

https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
content/renderer/render_frame_proxy.h:102: 
nit: No blank line here, since this is a list of methods overridden from
WebRemoteFrameClient.

[alexmos, 2014-09-25 21:42:22]

On 2014/09/25 20:17:52, nasko wrote:
> Just one drive-by comment.
> 
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> File content/renderer/render_frame_impl.cc (right):
> 
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> content/renderer/render_frame_impl.cc:1066: // Send initial drawing parameters
> to the frame being rendered remotely.
> nit: I'd put a comment that is more generic. Now it is just drawing, later on
> might be more, which will make the comment stale.

Done.  Let me know if this one's better.

[alexmos, 2014-09-25 21:43:09]

On 2014/09/25 20:53:17, Charlie Reis wrote:
> Great!  LGTM with nit.
> 
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> File content/renderer/render_frame_proxy.h (right):
> 
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> content/renderer/render_frame_proxy.h:102: 
> nit: No blank line here, since this is a list of methods overridden from
> WebRemoteFrameClient.

Done.  Thanks!

[nasko, 2014-09-25 21:51:26]

On 2014/09/25 21:42:22, alexmos wrote:
> On 2014/09/25 20:17:52, nasko wrote:
> > Just one drive-by comment.
> > 
> >
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> > File content/renderer/render_frame_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/592263002/diff/40001/content/renderer/render_...
> > content/renderer/render_frame_impl.cc:1066: // Send initial drawing
parameters
> > to the frame being rendered remotely.
> > nit: I'd put a comment that is more generic. Now it is just drawing, later
on
> > might be more, which will make the comment stale.
> 
> Done.  Let me know if this one's better.

Yes, looks better.

[Charlie Reis, 2014-09-25 21:52:35]

LGTM

[alexmos, 2014-09-25 22:03:34]

The CQ bit was checked by alexmos@chromium.org

[commit-bot: I haz the power, 2014-09-25 22:04:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/592263002/60001

[commit-bot: I haz the power, 2014-09-25 23:15:52]

Committed patchset #4 (id:60001) as 9f7bb80151a9272c9bf7021ff9a9c10f4f91b2db

[commit-bot: I haz the power, 2014-09-25 23:16:32]

Patchset 4 (id:??) landed as
https://crrev.com/05334c25134091e0bb662dd4793d63ed655b9b07
Cr-Commit-Position: refs/heads/master@{#296822}