Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 592223002: Remove unused plugin argument to skip virtual method checks in .cc files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/FindBadConstructsAction.cpp
diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
index be7a9506a78cd27737bade5303f4c727511d0ab8..ccf7f6397f256d0c5dab4199213b12e79f4c4b77 100644
--- a/tools/clang/plugins/FindBadConstructsAction.cpp
+++ b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -26,10 +26,7 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
bool parsed = true;
for (size_t i = 0; i < args.size() && parsed; ++i) {
- if (args[i] == "skip-virtuals-in-implementations") {
- // TODO(rsleevi): Remove this once http://crbug.com/115047 is fixed.
- options_.check_virtuals_in_implementations = false;
- } else if (args[i] == "check-base-classes") {
+ if (args[i] == "check-base-classes") {
// TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
options_.check_base_classes = true;
} else if (args[i] == "check-weak-ptr-factory-order") {
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698