Issue 592223002: Remove unused plugin argument to skip virtual method checks in .cc files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 592223002: Remove unused plugin argument to skip virtual method checks in .cc files (Closed)

Created:
6 years, 3 months ago by dcheng

Modified:
6 years, 3 months ago

Reviewers:
Nico, Ryan Sleevi

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove unused plugin argument to skip virtual method checks in .cc files BUG=115047 Committed: https://crrev.com/357e910cfff921cb0721ca51beac25cc69e25c90 Cr-Commit-Position: refs/heads/master@{#296159}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -12 lines)			Patch
M	tools/clang/plugins/FindBadConstructsAction.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tools/clang/plugins/FindBadConstructsConsumer.cpp	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	tools/clang/plugins/Options.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592223002/1

6 years, 3 months ago (2014-09-23 08:01:20 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as ba811ba637a9384128dda5e95f8edb3265007d2f

6 years, 3 months ago (2014-09-23 08:32:24 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-23 08:33:08 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/357e910cfff921cb0721ca51beac25cc69e25c90
Cr-Commit-Position: refs/heads/master@{#296159}