content/browser/mojo/mojo_application_host.cc - Issue 592153002: Replace Chrome IPC with Mojo IPC for querying BatteryStatus service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/mojo/mojo_application_host.cc

Issue 592153002: Replace Chrome IPC with Mojo IPC for querying BatteryStatus service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Tim's comments. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/mojo/mojo_application_host.h ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/mojo/mojo_application_host.cc

diff --git a/content/browser/mojo/mojo_application_host.cc b/content/browser/mojo/mojo_application_host.cc

index 3af797499e0b809e1652411e8670ab62f14ac26e..b7529731ed4be3a531e128f87798472dab3c234d 100644

--- a/content/browser/mojo/mojo_application_host.cc

+++ b/content/browser/mojo/mojo_application_host.cc

@@ -47,7 +47,7 @@ bool MojoApplicationHost::Init() {

return true;

}

-bool MojoApplicationHost::Activate(IPC::Sender* sender,

+void MojoApplicationHost::Activate(IPC::Sender* sender,

base::ProcessHandle process_handle) {

DCHECK(!did_activate_);

DCHECK(client_handle_.is_valid());

@@ -56,7 +56,6 @@ bool MojoApplicationHost::Activate(IPC::Sender* sender,

PlatformFileFromScopedPlatformHandle(client_handle_.Pass());

did_activate_ = sender->Send(new MojoMsg_Activate(

IPC::GetFileHandleForProcess(client_file, process_handle, true)));

- return did_activate_;

}

void MojoApplicationHost::WillDestroySoon() {