Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: device/battery/battery_status_service.cc

Issue 592153002: Replace Chrome IPC with Mojo IPC for querying BatteryStatus service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Tom's comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/battery_status/battery_status_service.h" 5 #include "device/battery/battery_status_service.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "content/browser/battery_status/battery_status_manager.h" 8 #include "base/message_loop/message_loop.h"
9 #include "content/public/browser/browser_thread.h" 9 #include "base/single_thread_task_runner.h"
10 #include "device/battery/battery_monitor_impl.h"
11 #include "device/battery/battery_status_manager.h"
10 12
11 namespace content { 13 namespace device {
12 14
13 BatteryStatusService::BatteryStatusService() 15 BatteryStatusService::BatteryStatusService()
14 : update_callback_(base::Bind(&BatteryStatusService::UpdateBatteryStatus, 16 : main_thread_task_runner_(base::MessageLoop::current()->task_runner()),
17 update_callback_(base::Bind(&BatteryStatusService::NotifyConsumers,
15 base::Unretained(this))), 18 base::Unretained(this))),
16 status_updated_(false), 19 status_updated_(false),
17 is_shutdown_(false) { 20 is_shutdown_(false) {
18 callback_list_.set_removal_callback( 21 callback_list_.set_removal_callback(
19 base::Bind(&BatteryStatusService::ConsumersChanged, 22 base::Bind(&BatteryStatusService::ConsumersChanged,
20 base::Unretained(this))); 23 base::Unretained(this)));
21 } 24 }
22 25
23 BatteryStatusService::~BatteryStatusService() { 26 BatteryStatusService::~BatteryStatusService() {
24 } 27 }
25 28
26 BatteryStatusService* BatteryStatusService::GetInstance() { 29 BatteryStatusService* BatteryStatusService::GetInstance() {
27 return Singleton<BatteryStatusService, 30 return Singleton<BatteryStatusService,
28 LeakySingletonTraits<BatteryStatusService> >::get(); 31 LeakySingletonTraits<BatteryStatusService> >::get();
29 } 32 }
30 33
31 scoped_ptr<BatteryStatusService::BatteryUpdateSubscription> 34 scoped_ptr<BatteryStatusService::BatteryUpdateSubscription>
32 BatteryStatusService::AddCallback(const BatteryUpdateCallback& callback) { 35 BatteryStatusService::AddCallback(const BatteryUpdateCallback& callback) {
33 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 36 DCHECK(main_thread_task_runner_->BelongsToCurrentThread());
34 DCHECK(!is_shutdown_); 37 DCHECK(!is_shutdown_);
35 38
36 if (!battery_fetcher_) 39 if (!battery_fetcher_)
37 battery_fetcher_ = BatteryStatusManager::Create(update_callback_); 40 battery_fetcher_ = BatteryStatusManager::Create(update_callback_);
38 41
39 if (callback_list_.empty()) { 42 if (callback_list_.empty()) {
40 bool success = battery_fetcher_->StartListeningBatteryChange(); 43 bool success = battery_fetcher_->StartListeningBatteryChange();
41 if (!success) { 44 // On failure pass the default values back.
42 // Make sure the promise resolves with the default values in Blink. 45 if (!success)
43 callback.Run(blink::WebBatteryStatus()); 46 callback.Run(BatteryStatus());
44 }
45 } 47 }
46 48
47 if (status_updated_) { 49 if (status_updated_) {
48 // Send recent status to the new callback if already available. 50 // Send recent status to the new callback if already available.
49 callback.Run(status_); 51 callback.Run(status_);
50 } 52 }
51 53
52 return callback_list_.Add(callback); 54 return callback_list_.Add(callback);
53 } 55 }
54 56
55 void BatteryStatusService::ConsumersChanged() { 57 void BatteryStatusService::ConsumersChanged() {
56 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 58 if (is_shutdown_)
57 DCHECK(!is_shutdown_); 59 return;
58 60
59 if (callback_list_.empty()) { 61 if (callback_list_.empty()) {
60 battery_fetcher_->StopListeningBatteryChange(); 62 battery_fetcher_->StopListeningBatteryChange();
61 status_updated_ = false; 63 status_updated_ = false;
62 } 64 }
63 } 65 }
64 66
65 void BatteryStatusService::UpdateBatteryStatus( 67 void BatteryStatusService::NotifyConsumers(const BatteryStatus& status) {
66 const blink::WebBatteryStatus& status) {
67 DCHECK(!is_shutdown_); 68 DCHECK(!is_shutdown_);
68 BrowserThread::PostTask(BrowserThread::IO, 69
69 FROM_HERE, 70 main_thread_task_runner_->PostTask(FROM_HERE, base::Bind(
70 base::Bind(&BatteryStatusService::NotifyConsumers, 71 &BatteryStatusService::NotifyConsumersOnMainThread,
71 base::Unretained(this), status)); 72 base::Unretained(this),
73 status));
72 } 74 }
73 75
74 void BatteryStatusService::NotifyConsumers( 76 void BatteryStatusService::NotifyConsumersOnMainThread(
75 const blink::WebBatteryStatus& status) { 77 const BatteryStatus& status) {
76 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); 78 DCHECK(main_thread_task_runner_->BelongsToCurrentThread());
77
78 if (callback_list_.empty()) 79 if (callback_list_.empty())
79 return; 80 return;
80 81
81 status_ = status; 82 status_ = status;
82 status_updated_ = true; 83 status_updated_ = true;
83 callback_list_.Notify(status); 84 callback_list_.Notify(status_);
84 } 85 }
85 86
86 void BatteryStatusService::Shutdown() { 87 void BatteryStatusService::Shutdown() {
87 if (!callback_list_.empty()) 88 if (!callback_list_.empty())
88 battery_fetcher_->StopListeningBatteryChange(); 89 battery_fetcher_->StopListeningBatteryChange();
89 battery_fetcher_.reset(); 90 battery_fetcher_.reset();
90 is_shutdown_ = true; 91 is_shutdown_ = true;
91 } 92 }
92 93
93 const BatteryStatusService::BatteryUpdateCallback& 94 const BatteryStatusService::BatteryUpdateCallback&
94 BatteryStatusService::GetUpdateCallbackForTesting() const { 95 BatteryStatusService::GetUpdateCallbackForTesting() const {
95 return update_callback_; 96 return update_callback_;
96 } 97 }
97 98
98 void BatteryStatusService::SetBatteryManagerForTesting( 99 void BatteryStatusService::SetBatteryManagerForTesting(
99 BatteryStatusManager* test_battery_manager) { 100 scoped_ptr<BatteryStatusManager> test_battery_manager) {
100 battery_fetcher_.reset(test_battery_manager); 101 battery_fetcher_ = test_battery_manager.Pass();
101 blink::WebBatteryStatus status; 102 status_ = BatteryStatus();
102 status_ = status;
103 status_updated_ = false; 103 status_updated_ = false;
104 } 104 }
105 105
106 } // namespace content 106 } // namespace device
OLDNEW
« no previous file with comments | « device/battery/battery_status_service.h ('k') | device/battery/battery_status_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698