Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tools/isolate_driver.py

Issue 592143002: Make isolate_driver.py only add .dll/.so/.dylib for component builds' generated files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate_driver.py
diff --git a/tools/isolate_driver.py b/tools/isolate_driver.py
index 40f0c6dbb944c114eb4a7600198a597281762ad1..f8602fbfb609eeac9cb2908092acd885b201767f 100755
--- a/tools/isolate_driver.py
+++ b/tools/isolate_driver.py
@@ -177,6 +177,12 @@ def post_process_deps(build_dir, dependencies):
return i
def f(i):
+ # This script is only for adding new binaries that are created as part of
+ # the component build.
+ ext = os.path.splitext(i)[1]
+ if ext not in ['.dll', '.so', '.dylib']:
+ return False
+
# Check for execute access and strip directories. This gets rid of all the
# phony rules.
p = os.path.join(build_dir, i)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698