Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 592143002: Make isolate_driver.py only add .dll/.so/.dylib for component builds' generated files. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make isolate_driver.py only add .dll/.so/.dylib for component builds' generated files. Right now it's adding a lot of other files that aren't needed to run the tests, which slows down the uploading and downloading steps when using component builds. Since this preprocessing step is only meant to add extra binaries that are the result of the component build, just whitelist .dll/.so/.dylib. BUG=414808 Committed: https://crrev.com/3e06ba0e663c5a1cc7e87f4b814ecd8d3f00c179 Cr-Commit-Position: refs/heads/master@{#296037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/isolate_driver.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
6 years, 3 months ago (2014-09-22 17:45:35 UTC) #2
jam
as one datapoint, this drops the generated content_unittests.isolate file from > 2K lines to under ...
6 years, 3 months ago (2014-09-22 17:53:23 UTC) #3
M-A Ruel
Ugh, no idea why I hadn't done this in the first place. lgtm
6 years, 3 months ago (2014-09-22 18:15:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592143002/1
6 years, 3 months ago (2014-09-22 19:12:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 65038978f1ef837b23e658c29264fea8c558ae4a
6 years, 3 months ago (2014-09-22 20:26:30 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 20:27:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e06ba0e663c5a1cc7e87f4b814ecd8d3f00c179
Cr-Commit-Position: refs/heads/master@{#296037}

Powered by Google App Engine
This is Rietveld 408576698