Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: tests/standalone/io/http_connection_info_test.dart

Issue 59213003: Rename remoteHost to remoteAddress on *Socket. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added mac/win/android versions. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/socket.dart ('k') | tests/standalone/io/socket_info_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/http_connection_info_test.dart
diff --git a/tests/standalone/io/http_connection_info_test.dart b/tests/standalone/io/http_connection_info_test.dart
index 0d4caa4645b6b2b37d47e0a2a341e31c0453934e..e503803b4b52722cdbfbc408454583dca7335ff8 100644
--- a/tests/standalone/io/http_connection_info_test.dart
+++ b/tests/standalone/io/http_connection_info_test.dart
@@ -11,8 +11,8 @@ void testHttpConnectionInfo() {
server.listen((request) {
var response = request.response;
- Expect.isTrue(request.connectionInfo.remoteHost is String);
- Expect.isTrue(response.connectionInfo.remoteHost is String);
+ Expect.isTrue(request.connectionInfo.remoteAddress is InternetAddress);
+ Expect.isTrue(response.connectionInfo.remoteAddress is InternetAddress);
Expect.equals(request.connectionInfo.localPort, server.port);
Expect.equals(response.connectionInfo.localPort, server.port);
Expect.isNotNull(clientPort);
@@ -26,7 +26,8 @@ void testHttpConnectionInfo() {
HttpClient client = new HttpClient();
client.get("127.0.0.1", server.port, "/")
.then((request) {
- Expect.isTrue(request.connectionInfo.remoteHost is String);
+ Expect.isTrue(
+ request.connectionInfo.remoteAddress is InternetAddress);
Expect.equals(request.connectionInfo.remotePort, server.port);
clientPort = request.connectionInfo.localPort;
return request.close();
« no previous file with comments | « sdk/lib/io/socket.dart ('k') | tests/standalone/io/socket_info_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698