Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_label.dart

Issue 592123002: Move SourceReference, extract duplicate code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/rename_label.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_label.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_label.dart
index 9824b0e8e3fc120ee91ed8de6e9f230e9f156ef5..b417056c20243d3f6e889f45f4dd159fa07836ee 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/rename_label.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_label.dart
@@ -6,7 +6,6 @@ library services.src.refactoring.rename_label;
import 'dart:async';
-import 'package:analysis_server/src/protocol.dart' hide Element;
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/naming_conventions.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
@@ -42,17 +41,8 @@ class RenameLabelRefactoringImpl extends RenameRefactoringImpl {
}
@override
- Future<SourceChange> createChange() {
- SourceChange change = new SourceChange(refactoringName);
- // update declaration
- addDeclarationEdit(change, element);
- // update references
- return searchEngine.searchReferences(element).then((refMatches) {
- List<SourceReference> references = getSourceReferences(refMatches);
- for (SourceReference reference in references) {
- addReferenceEdit(change, reference);
- }
- return change;
- });
+ Future fillChange() {
+ addDeclarationEdit(element);
+ return searchEngine.searchReferences(element).then(addReferenceEdits);
}
}

Powered by Google App Engine
This is Rietveld 408576698