Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart

Issue 592123002: Move SourceReference, extract duplicate code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart b/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart
index 32764189f3ba05557d878e28d9b483fa9073e9dc..3f727440c272a5f2e6b6e06def0472360b126da2 100644
--- a/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart
+++ b/pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart
@@ -5,9 +5,37 @@
library services.src.refactoring;
import 'dart:async';
+import 'dart:collection';
+import 'package:analysis_server/src/protocol.dart' hide Element;
import 'package:analysis_server/src/services/correction/status.dart';
import 'package:analysis_server/src/services/refactoring/refactoring.dart';
+import 'package:analysis_server/src/services/search/search_engine.dart';
+import 'package:analyzer/src/generated/element.dart';
+import 'package:analyzer/src/generated/source.dart';
+
+
+/**
+ * When a [Source] (a file) is used in more than one context, [SearchEngine]
+ * will return separate [SearchMatch]s for each context. But in rename
+ * refactorings we want to update each [Source] only once.
+ */
+List<SourceReference> getSourceReferences(List<SearchMatch> matches) {
+ var uniqueReferences = new HashMap<SourceReference, SourceReference>();
+ for (SearchMatch match in matches) {
+ Element element = match.element;
+ String file = element.source.fullName;
+ SourceRange range = match.sourceRange;
+ SourceReference newReference =
+ new SourceReference(file, range, element, match.isResolved, match.isQualified);
+ SourceReference oldReference = uniqueReferences[newReference];
+ if (oldReference == null) {
+ uniqueReferences[newReference] = newReference;
+ oldReference = newReference;
+ }
+ }
+ return uniqueReferences.keys.toList();
+}
/**
@@ -31,3 +59,54 @@ abstract class RefactoringImpl implements Refactoring {
});
}
}
+
+
+/**
+ * The [SourceRange] in some [Source].
+ */
+class SourceReference {
+ final String file;
+ final SourceRange range;
+ final Element element;
+ final bool isResolved;
+ final bool isQualified;
+
+ SourceReference(this.file, this.range, this.element, this.isResolved,
+ this.isQualified);
+
+ @override
+ int get hashCode {
+ int hash = file.hashCode;
+ hash = ((hash << 16) & 0xFFFFFFFF) + range.hashCode;
+ return hash;
+ }
+
+ @override
+ bool operator ==(Object other) {
+ if (identical(other, this)) {
+ return true;
+ }
+ if (other is SourceReference) {
+ return other.file == file && other.range == range;
+ }
+ return false;
+ }
+
+ /**
+ * Adds the [SourceEdit] to replace this reference.
+ */
+ void addEdit(SourceChange change, String newText, {String id}) {
+ SourceEdit edit = createEdit(newText, id: id);
+ change.addElementEdit(element, edit);
+ }
+
+ /**
+ * Returns the [SourceEdit] to replace this reference.
+ */
+ SourceEdit createEdit(String newText, {String id}) {
+ return new SourceEdit.range(range, newText, id: id);
+ }
+
+ @override
+ String toString() => '${file}@${range}';
+}

Powered by Google App Engine
This is Rietveld 408576698