Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 592033002: Fix DebugEvaluate on properties defined on Object.prototype (Closed)

Created:
6 years, 3 months ago by aandrey
Modified:
6 years, 3 months ago
Reviewers:
yangguo, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix DebugEvaluate on properties defined on Object.prototype BUG=415499 R=yangguo LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24119

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M src/runtime.cc View 1 2 chunks +11 lines, -2 lines 0 comments Download
M test/cctest/test-debug.cc View 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
aandrey
6 years, 3 months ago (2014-09-22 10:15:37 UTC) #1
Yang
On 2014/09/22 10:15:37, aandrey wrote: lgtm!
6 years, 3 months ago (2014-09-22 10:25:22 UTC) #2
aandrey
6 years, 3 months ago (2014-09-22 12:45:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698