Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 592003002: AX: Calendar Picker: Add a test for input[type=week]. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

AX: Calendar Picker: Add a test for input[type=week]. This CL adds a test for Blink r182213 [1] and Chromium #295859 [2]. [1] http://src.chromium.org/viewvc/blink?view=revision&revision=182213 [2] https://crrev.com/4968e8da39022d26a07e57eef215612f21cbab10 BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
A + LayoutTests/fast/forms/calendar-picker/week-picker-ax.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/forms/calendar-picker/week-picker-ax-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-22 08:29:47 UTC) #2
keishi
lgtm
6 years, 3 months ago (2014-09-24 03:03:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592003002/1
6 years, 3 months ago (2014-09-24 03:04:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 182548
6 years, 3 months ago (2014-09-24 03:09:07 UTC) #6
Mads Ager (chromium)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/601693002/ by ager@chromium.org. ...
6 years, 3 months ago (2014-09-24 06:45:10 UTC) #7
tkent
6 years, 2 months ago (2014-09-25 06:26:52 UTC) #8
Message was sent while issue was closed.
On 2014/09/24 06:45:10, Mads Ager (chromium) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/601693002/ by mailto:ager@chromium.org.
> 
> The reason for reverting is: This test is failing consistently on the
buildbots.
> Reverting for now. Can you investigate and reland Kent?
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fas....

Found the root cause.  The current code works well only if ASSERT is enabled. 
Release try bots have asserts, and release waterfall bots have no asserts.

Powered by Google App Engine
This is Rietveld 408576698