Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 591993002: Fix WeakPtrFactory member ordering in chrome/browser/sync (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix WeakPtrFactory member ordering in chrome/browser/sync Changing the initialization order of WeakPtrFactory such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Committed: https://crrev.com/771fbabbbf5c8fca3f2efb2aeb6885f16c52be98 Cr-Commit-Position: refs/heads/master@{#296005}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/sync/sessions/notification_service_sessions_router.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
On 2014/09/22 07:33:58, anujsharma wrote: > mailto:anujk.sharma@samsung.com changed reviewers: > + mailto:maniscalco@chromium.org PTAL
6 years, 3 months ago (2014-09-22 07:34:11 UTC) #2
maniscalco
lgtm
6 years, 3 months ago (2014-09-22 15:40:35 UTC) #3
anujsharma
On 2014/09/22 15:40:35, maniscalco wrote: > lgtm Thanks maniscalco for lgtm.
6 years, 3 months ago (2014-09-22 16:26:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591993002/1
6 years, 3 months ago (2014-09-22 16:27:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as d630267a0f3ace7ea88d3ad0fc1a36449f64f9aa
6 years, 3 months ago (2014-09-22 17:20:22 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 17:21:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/771fbabbbf5c8fca3f2efb2aeb6885f16c52be98
Cr-Commit-Position: refs/heads/master@{#296005}

Powered by Google App Engine
This is Rietveld 408576698