Fix WeakPtrFactory member ordering in chrome/browser/sync

Fix WeakPtrFactory member ordering in chrome/browser/sync

Changing the initialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818
Committed: https://crrev.com/771fbabbbf5c8fca3f2efb2aeb6885f16c52be98
Cr-Commit-Position: refs/heads/master@{#296005}

[anujsharma, 2014-09-22 07:33:58]

anujk.sharma@samsung.com changed reviewers:
+ maniscalco@chromium.org

[anujsharma, 2014-09-22 07:34:11]

On 2014/09/22 07:33:58, anujsharma wrote:
> mailto:anujk.sharma@samsung.com changed reviewers:
> + mailto:maniscalco@chromium.org

PTAL

[maniscalco, 2014-09-22 15:40:35]

lgtm

[anujsharma, 2014-09-22 16:26:43]

On 2014/09/22 15:40:35, maniscalco wrote:
> lgtm

Thanks maniscalco for lgtm.

[anujsharma, 2014-09-22 16:26:52]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2014-09-22 16:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591993002/1

[commit-bot: I haz the power, 2014-09-22 17:20:22]

Committed patchset #1 (id:1) as d630267a0f3ace7ea88d3ad0fc1a36449f64f9aa

[commit-bot: I haz the power, 2014-09-22 17:21:14]

Patchset 1 (id:??) landed as
https://crrev.com/771fbabbbf5c8fca3f2efb2aeb6885f16c52be98
Cr-Commit-Position: refs/heads/master@{#296005}