[SyncFS] Add RemoteToLocalSyncer skeleton

[SyncFS] Add RemoteToLocalSyncer skeleton

 * Implements RemoteToLocalSyncer by the main point
 * Add necessary functions of MetadataDatabase as skeletons

BUG=240165
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233249

[tzik, 2013-11-05 12:20:49]

PTL

[kinuko, 2013-11-05 13:36:13]

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.h:235: void
ResolveTrivialDirtiness(int64 tracker_id,
Can you add a comment? What's the definition of 'trivial' here?

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:50: if
(metadata_database()->GetNormalPriorityDirtyTracker(&dirty_tracker_)) {
GetLowPriorityDirtyTracker?

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h
(right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h:32: int
priorities);
Please add a comment.

"|priorities| must be a bitwise-or'd value of Priority."

And also add a note about how it changes the syncer's behavior.

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:123: this,
RemoteToLocalSyncer::PRIORITY_NORMAL);
When do we use PRIORITY_LOW?

[tzik, 2013-11-06 04:56:07]

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/metadata_database.h (right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/metadata_database.h:235: void
ResolveTrivialDirtiness(int64 tracker_id,
On 2013/11/05 13:36:13, kinuko wrote:
> Can you add a comment? What's the definition of 'trivial' here?

Hm, let me move this to RemoteToLocalSyncer, and rename it to
OfflineSolvableDirtiness.

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:50: if
(metadata_database()->GetNormalPriorityDirtyTracker(&dirty_tracker_)) {
On 2013/11/05 13:36:13, kinuko wrote:
> GetLowPriorityDirtyTracker?

Done.

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h
(right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h:32: int
priorities);
On 2013/11/05 13:36:13, kinuko wrote:
> Please add a comment.
> 
> "|priorities| must be a bitwise-or'd value of Priority."
> 
> And also add a note about how it changes the syncer's behavior.

Done.

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right):

https://codereview.chromium.org/59193003/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/sync_engine.cc:123: this,
RemoteToLocalSyncer::PRIORITY_NORMAL);
On 2013/11/05 13:36:13, kinuko wrote:
> When do we use PRIORITY_LOW?

Added a comment to RemoteToLocalSyncer.
I'll mark conflicting tracker as priority low, to handle it later.

[kinuko, 2013-11-06 05:23:38]

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(right):

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:103:
bool unknown_parent = metadata_database()->FindTrackerByTrackerID(
hmm, !FindTrackerByTrackerID(...) ??

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:169: 
nit: extra empty line

[tzik, 2013-11-06 05:41:28]

Updated! PTAL.

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc
(right):

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:103:
bool unknown_parent = metadata_database()->FindTrackerByTrackerID(
On 2013/11/06 05:23:38, kinuko wrote:
> hmm, !FindTrackerByTrackerID(...) ??

Done.

https://codereview.chromium.org/59193003/diff/120001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:169: 
On 2013/11/06 05:23:38, kinuko wrote:
> nit: extra empty line

Done.

[kinuko, 2013-11-06 05:46:14]

Ok, lgtm

Let's revisit low-priority one after we have better view for sync flow.

[commit-bot: I haz the power, 2013-11-06 06:15:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/59193003/170001

[commit-bot: I haz the power, 2013-11-06 09:23:38]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 09:26:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/59193003/170001

[commit-bot: I haz the power, 2013-11-06 09:28:00]

Change committed as 233249