Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2019)

Unified Diff: athena/content/render_view_context_menu_impl.cc

Issue 591803002: Add athena_strings.grd with athena specific strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « athena/content/DEPS ('k') | athena/content/web_activity.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/render_view_context_menu_impl.cc
diff --git a/athena/content/render_view_context_menu_impl.cc b/athena/content/render_view_context_menu_impl.cc
index 82f6098e8b2b8ea2a78ecd532ed2f7639eb673c7..688b4f5e1e7b68e2695d5e90169007f2284310fa 100644
--- a/athena/content/render_view_context_menu_impl.cc
+++ b/athena/content/render_view_context_menu_impl.cc
@@ -4,12 +4,13 @@
#include "athena/content/render_view_context_menu_impl.h"
-#include "base/strings/utf_string_conversions.h"
+#include "athena/strings/grit/athena_strings.h"
#include "components/renderer_context_menu/context_menu_content_type.h"
#include "components/renderer_context_menu/views/toolkit_delegate_views.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/web_contents.h"
#include "third_party/WebKit/public/web/WebContextMenuData.h"
+#include "ui/base/l10n/l10n_util.h"
namespace athena {
using blink::WebContextMenuData;
@@ -44,32 +45,46 @@ const int kNumCustomCommandIds = 1000;
// TODO(oshima): Move IDS for context menus to components/renderer_context_menu
// and replace hardcoded strings below.
void AppendPageItems(ui::SimpleMenuModel* menu_model) {
- menu_model->AddItem(CMD_BACK, base::ASCIIToUTF16("Back"));
- menu_model->AddItem(CMD_FORWARD, base::ASCIIToUTF16("Forward"));
- menu_model->AddItem(CMD_RELOAD, base::ASCIIToUTF16("Reload"));
+ menu_model->AddItem(CMD_BACK,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_BACK));
+ menu_model->AddItem(CMD_FORWARD,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_FORWARD));
+ menu_model->AddItem(CMD_RELOAD,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_RELOAD));
menu_model->AddSeparator(ui::NORMAL_SEPARATOR);
- menu_model->AddItem(CMD_VIEW_SOURCE, base::ASCIIToUTF16("View Source"));
+ menu_model->AddItem(
+ CMD_VIEW_SOURCE,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_VIEWPAGESOURCE));
}
void AppendLinkItems(const content::ContextMenuParams& params,
ui::SimpleMenuModel* menu_model) {
if (!params.link_url.is_empty())
- menu_model->AddItem(CMD_OPEN_LINK_NEW_ACTIVITY,
- base::ASCIIToUTF16("Open Link In New Activity"));
+ menu_model->AddItem(
+ CMD_OPEN_LINK_NEW_ACTIVITY,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_OPENLINKNEWACTIVITY));
}
void AppendEditableItems(ui::SimpleMenuModel* menu_model) {
- menu_model->AddItem(CMD_UNDO, base::ASCIIToUTF16("Undo"));
- menu_model->AddItem(CMD_REDO, base::ASCIIToUTF16("Redo"));
+ menu_model->AddItem(CMD_UNDO,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_UNDO));
+ menu_model->AddItem(CMD_REDO,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_REDO));
menu_model->AddSeparator(ui::NORMAL_SEPARATOR);
- menu_model->AddItem(CMD_CUT, base::ASCIIToUTF16("Cut"));
- menu_model->AddItem(CMD_COPY, base::ASCIIToUTF16("Copy"));
- menu_model->AddItem(CMD_PASTE, base::ASCIIToUTF16("Paste"));
- menu_model->AddItem(CMD_PASTE_AND_MATCH_STYLE,
- base::ASCIIToUTF16("Paste as plain text"));
- menu_model->AddItem(CMD_DELETE, base::ASCIIToUTF16("Delete"));
+ menu_model->AddItem(CMD_CUT,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_CUT));
+ menu_model->AddItem(CMD_COPY,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_COPY));
+ menu_model->AddItem(CMD_PASTE,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_PASTE));
+ menu_model->AddItem(
+ CMD_PASTE_AND_MATCH_STYLE,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_PASTE_AND_MATCH_STYLE));
+ menu_model->AddItem(CMD_DELETE,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_DELETE));
menu_model->AddSeparator(ui::NORMAL_SEPARATOR);
- menu_model->AddItem(CMD_SELECT_ALL, base::ASCIIToUTF16("Select All"));
+ menu_model->AddItem(CMD_SELECT_ALL,
+ l10n_util::GetStringUTF16(IDS_ATHENA_CONTEXT_SELECTALL));
}
} // namespace
« no previous file with comments | « athena/content/DEPS ('k') | athena/content/web_activity.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698