Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/gritsettings/resource_ids

Issue 591803002: Add athena_strings.grd with athena specific strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« athena/athena_strings.gyp ('K') | « tools/check_grd_for_unused_strings.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gritsettings/resource_ids
diff --git a/tools/gritsettings/resource_ids b/tools/gritsettings/resource_ids
index 9cd707cc254204eddec5e214e1b50c1482473ac4..01b6956aa4d9947344a7f27d889d5070497607f8 100644
--- a/tools/gritsettings/resource_ids
+++ b/tools/gritsettings/resource_ids
@@ -223,6 +223,9 @@
"third_party/WebKit/public/blink_resources.grd": {
"includes": [30500],
},
+ "athena/athena_strings.grd": {
+ "messages": [42000],
oshima 2014/09/24 17:55:19 isn't it better to put this before blink resources
pkotwicz 2014/09/24 20:44:48 I do not want to get too close to the max id used
oshima 2014/09/25 00:41:59 You can just update the ids after ash
+ },
# These files don't need to reserve resource ids, but are listed here so that
# translation scripts know of their existence.
« athena/athena_strings.gyp ('K') | « tools/check_grd_for_unused_strings.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698