Refactoring: Remove more legacy from release scripts.

tools/push-to-trunk/bump_up_version.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 Script for auto-increasing the version on bleeding_edge.
 
 The script can be run regularly by a cron job. It will increase the build
 level of the version on bleeding_edge if:
@@ skipping 10 matching lines @@
 
 import argparse
 import os
 import sys
 
 from common_includes import *
 
 CONFIG = {
   PERSISTFILE_BASENAME: "/tmp/v8-bump-up-version-tempfile",
   PATCH_FILE: "/tmp/v8-bump-up-version-tempfile-patch-file",
-  VERSION_FILE: "src/version.cc",
 }
 
 VERSION_BRANCH = "auto-bump-up-version"
 
 
 class Preparation(Step):
   MESSAGE = "Preparation."
 
   def RunStep(self):
     # Check for a clean workdir.
@@ skipping 24 matching lines @@
     print "Bleeding edge version: %s" % self["latest_version"]
 
 
 # This step is pure paranoia. It forbids the script to continue if the last
 # commit changed version.cc. Just in case the other bailout has a bug, this
 # prevents the script from continuously commiting version changes.
 class LastChangeBailout(Step):
   MESSAGE = "Stop script if the last change modified the version."
 
   def RunStep(self):
-    if self._config[VERSION_FILE] in self.GitChangedFiles(self["latest"]):
+    if VERSION_FILE in self.GitChangedFiles(self["latest"]):
       print "Stop due to recent version change."
       return True
 
 
 # TODO(machenbach): Implement this for git.
 class FetchLKGR(Step):
   MESSAGE = "Fetching V8 LKGR."
 
   def RunStep(self):
     lkgr_url = "https://v8-status.appspot.com/lkgr"
@@ skipping 28 matching lines @@
     self.GitCheckout("bleeding_edge")
     self.DeleteBranch(VERSION_BRANCH)
 
 
 class LKGRVersionUpToDateBailout(Step):
   MESSAGE = "Stop script if the lkgr has a renewed version."
 
   def RunStep(self):
     # If a version-change commit becomes the lkgr, don't bump up the version
     # again.
-    if self._config[VERSION_FILE] in self.GitChangedFiles(self["lkgr"]):
+    if VERSION_FILE in self.GitChangedFiles(self["lkgr"]):
       print "Stop because the lkgr is a version change itself."
       return True
 
     # Don't bump up the version if it got updated already after the lkgr.
     if SortingKey(self["lkgr_version"]) < SortingKey(self["latest_version"]):
       print("Stop because the latest version already changed since the lkgr "
             "version.")
       return True
 
 
@@ skipping 51 matching lines @@
       print "Skip version change by tree status: \"%s\"" % message
       return True
 
 
 class ChangeVersion(Step):
   MESSAGE = "Bump up the version."
 
   def RunStep(self):
     self.GitCreateBranch(VERSION_BRANCH, "bleeding_edge")
 
-    self.SetVersion(self.Config(VERSION_FILE), "new_")
+    self.SetVersion(os.path.join(self.default_cwd, VERSION_FILE), "new_")
 
     try:
       msg = "[Auto-roll] Bump up version to %s" % self["new_version"]
       self.GitCommit("%s\n\nTBR=%s" % (msg, self._options.author),
                      author=self._options.author)
       if self._options.svn:
         self.SVNCommit("branches/bleeding_edge", msg)
       else:
         self.GitUpload(author=self._options.author,
                        force=self._options.force_upload,
@@ skipping 29 matching lines @@
       GetLKGRVersion,
       LKGRVersionUpToDateBailout,
       GetTrunkVersion,
       CalculateVersion,
       CheckTreeStatus,
       ChangeVersion,
     ]
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(BumpUpVersion(CONFIG).Run())