Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 591753002: Revert of Update V8 to version 3.29.75 (based on bleeding_edge revision r24018). (Closed)

Created:
6 years, 3 months ago by amineer_google
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 3.29.75 (based on bleeding_edge revision r24018). (patchset #1 id:1 of https://codereview.chromium.org/579123002/) Reason for revert: This roll appears to be causing major crashing. BUG=416185 Original issue's description: > Update V8 to version 3.29.75 (based on bleeding_edge revision r24018). > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/73d6505aac73a6382fb8596153a2ea6f289df620 > Cr-Commit-Position: refs/heads/master@{#295435} TBR=machenbach@chromium.org,v8-autoroll@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b3988855bf04e5a11195468c53dff88c4537b773 Cr-Commit-Position: refs/heads/master@{#295806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
amineer_google
Created Revert of Update V8 to version 3.29.75 (based on bleeding_edge revision r24018).
6 years, 3 months ago (2014-09-19 23:18:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591753002/1
6 years, 3 months ago (2014-09-19 23:20:06 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-19 23:20:08 UTC) #4
kareng
On 2014/09/19 23:20:08, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 3 months ago (2014-09-19 23:23:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591753002/1
6 years, 3 months ago (2014-09-19 23:24:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6c49f14fb6f2af099949de2b788bb100ff7fcc60
6 years, 3 months ago (2014-09-19 23:26:05 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b3988855bf04e5a11195468c53dff88c4537b773 Cr-Commit-Position: refs/heads/master@{#295806}
6 years, 3 months ago (2014-09-19 23:28:04 UTC) #9
Michael Achenbach
6 years, 3 months ago (2014-09-20 07:46:05 UTC) #10
Message was sent while issue was closed.
The version of v8 in the crashy chrome is 3.29.78.0 according to
http://omahaproxy.appspot.com/. That got already reverted because the perf
waterfall revealed some crashes. I assume you also reverted 3.29.75 to get back
to the last known canary revision, which is fine.

Powered by Google App Engine
This is Rietveld 408576698