Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 59173006: [Android] Fix missing onSingleTapConfirmed calls in GestureDetector (Closed)

Created:
7 years, 1 month ago by jdduke (slow)
Modified:
7 years, 1 month ago
Reviewers:
joth
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Fix missing onSingleTapConfirmed calls in GestureDetector Eliminate the short period of time between the tap timeout and long press causing onSingleTapConfirmed not to be dispatched when apps expect. Note: This is a cherry-pick of the upstream Android fix for b/8124095. BUG=315124 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233192

Patch Set 1 #

Patch Set 2 : Findbugs fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/third_party/GestureDetector.java View 8 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jdduke (slow)
joth@: Could you take a look? This is a direct cherry-pick of https://github.com/android/platform_frameworks_base/commit/eca3e6065ee6ce26027ef792d106f2f754a3169d Thanks.
7 years, 1 month ago (2013-11-05 16:21:46 UTC) #1
joth
lgtm FWIW I guess the definitive source of the patch is https://android.googlesource.com/platform/frameworks/base/+/eca3e6065ee6ce26027ef792d106f2f754a3169d%5E%21/
7 years, 1 month ago (2013-11-05 19:17:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/59173006/1
7 years, 1 month ago (2013-11-05 19:46:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=119812
7 years, 1 month ago (2013-11-05 21:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/59173006/290001
7 years, 1 month ago (2013-11-06 02:06:44 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 02:17:32 UTC) #6
Message was sent while issue was closed.
Change committed as 233192

Powered by Google App Engine
This is Rietveld 408576698