Issue 59173005: Show perlin issue

Issue 59173005: Show perlin issue (Closed)

Created:
7 years, 1 month ago by bsalomon

Modified:
7 years, 1 month ago

Reviewers:
sugoi1, Stephen White, sugoi

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Perlin issue fixed BUG=skia:1799 Committed: http://code.google.com/p/skia/source/detail?r=12150

Patch Set 2 : Fixed 0 octave issue #

Patch Set 3 : Added gm suppression #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gm/perlinnoise.cpp	View	1	2 chunks	+13 lines, -9 lines	0 comments	Download
M	src/effects/SkPerlinNoiseShader.cpp	View	1	2 chunks	+11 lines, -0 lines	1 comment	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

sugoi1

I added the fix directly in this cl, so you can have a look at ...

7 years, 1 month ago (2013-11-05 20:26:00 UTC) #1

bsalomon

lgtm https://codereview.chromium.org/59173005/diff/50001/src/effects/SkPerlinNoiseShader.cpp File src/effects/SkPerlinNoiseShader.cpp (right): https://codereview.chromium.org/59173005/diff/50001/src/effects/SkPerlinNoiseShader.cpp#newcode1304 src/effects/SkPerlinNoiseShader.cpp:1304: SkAutoTUnref<SkColorFilter> cf(SkColorFilter::CreateModeFilter( Ha.. ok.

7 years, 1 month ago (2013-11-05 20:30:21 UTC) #2

sugoi1

On 2013/11/05 20:30:21, bsalomon wrote: > lgtm > > https://codereview.chromium.org/59173005/diff/50001/src/effects/SkPerlinNoiseShader.cpp > File src/effects/SkPerlinNoiseShader.cpp (right): > ...

7 years, 1 month ago (2013-11-05 20:33:33 UTC) #3

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 1 month ago (2013-11-05 20:34:11 UTC) #4

bsalomon

On 2013/11/05 20:41:33, sugoi1 wrote: lgtm Dunno why it didn't like my first one.

7 years, 1 month ago (2013-11-05 20:43:26 UTC) #6

bsalomon

On 2013/11/05 20:43:26, bsalomon wrote: > On 2013/11/05 20:41:33, sugoi1 wrote: > > lgtm > ...

7 years, 1 month ago (2013-11-05 20:43:40 UTC) #7

bsalomon

On 2013/11/05 20:43:40, bsalomon wrote: > On 2013/11/05 20:43:26, bsalomon wrote: > > On 2013/11/05 ...

7 years, 1 month ago (2013-11-05 20:44:56 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/59173005/50001

7 years, 1 month ago (2013-11-05 20:45:51 UTC) #10

Message was sent while issue was closed.

Change committed as 12150

Expand Messages | Collapse Messages