Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: build/common.gypi

Issue 591723003: Revert of Enable incremental linking for static_library too (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_dll.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f7d82a1f01e21ddee004f458e83754ab69c6d145..d5d5a5960c02e9602d9f23ee3c5ab6f2aa6fe43c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -1903,11 +1903,11 @@
['asan==1', {
'win_use_allocator_shim%': 0,
}],
- ['buildtype!="Official"', {
- # Not enabled in Official because it adds padding to builds.
- # Enabled for both shared_library and static_library on an
- # experimental basis to see if it improves windows cycle times,
- # see http://crbug.com/404809.
+ ['component=="shared_library" and "<(GENERATOR)"=="ninja"', {
+ # Only enabled by default for ninja because it's buggy in VS.
+ # Not enabled for component=static_library because some targets
+ # are too large and the toolchain fails due to the size of the
+ # .obj files.
'incremental_chrome_dll%': 1,
}],
# Don't do incremental linking for large modules on 32-bit or when
@@ -3319,17 +3319,6 @@
# information is used by the Syzygy optimization tool when
# decomposing the release image.
'Profile': 'true',
-
- 'conditions': [
- ['incremental_chrome_dll', {
- # During bring-up of Release incremental, have the linker emit
- # a one line diagnostic describing why incremental linking
- # failed, when it does. http://crbug.com/404809.
- 'AdditionalOptions': [
- '/verbose:incr',
- ],
- }],
- ],
},
},
'conditions': [
« no previous file with comments | « no previous file | chrome/chrome_dll.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698