Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 591723002: [ChromeDriver] Fix clicking a map area broken by blink change 180610. (Closed)

Created:
6 years, 3 months ago by stgao
Modified:
6 years, 3 months ago
Reviewers:
samuong
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ChromeDriver] Fix clicking a map area broken by blink change 180610. NOTRY=true Committed: https://crrev.com/e3134c1b6ba0cf2b1efb256c8d4b1004ef70da41 Cr-Commit-Position: refs/heads/master@{#295910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/test/chromedriver/js/get_element_region.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
stgao
6 years, 3 months ago (2014-09-19 23:50:48 UTC) #2
stgao
Hi Sam, PTAL at this CL. If you give a lg2m, please help check the ...
6 years, 3 months ago (2014-09-20 06:22:07 UTC) #3
samuong
On 2014/09/20 06:22:07, Shuotao wrote: > Hi Sam, > > PTAL at this CL. > ...
6 years, 3 months ago (2014-09-20 06:31:11 UTC) #4
stgao
On 2014/09/20 06:31:11, samuong wrote: > On 2014/09/20 06:22:07, Shuotao wrote: > > Hi Sam, ...
6 years, 3 months ago (2014-09-20 07:50:32 UTC) #5
samuong
On 2014/09/20 07:50:32, Shuotao wrote: > On 2014/09/20 06:31:11, samuong wrote: > > On 2014/09/20 ...
6 years, 3 months ago (2014-09-21 19:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591723002/1
6 years, 3 months ago (2014-09-21 19:56:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 63b6e67d6090d9beac186f1ee71fcbca28282d7d
6 years, 3 months ago (2014-09-21 19:57:16 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-21 19:57:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3134c1b6ba0cf2b1efb256c8d4b1004ef70da41
Cr-Commit-Position: refs/heads/master@{#295910}

Powered by Google App Engine
This is Rietveld 408576698