Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 591703002: Fixing the locale problem in scope approval dialog (Closed)

Created:
6 years, 3 months ago by fgorski
Modified:
6 years, 3 months ago
Reviewers:
Michael Courage
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing the locale problem in scope approval dialog BUG=285481 R=courage@chromium.org Committed: https://crrev.com/1d1916b21bb418f3d35b4efcba4853eefaf10f01 Cr-Commit-Position: refs/heads/master@{#296142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/api/identity/identity_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fgorski
PTAL
6 years, 3 months ago (2014-09-19 22:27:53 UTC) #1
Michael Courage
On 2014/09/19 22:27:53, fgorski wrote: > PTAL lgtm
6 years, 3 months ago (2014-09-22 21:21:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591703002/1
6 years, 3 months ago (2014-09-22 21:25:01 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-22 23:26:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591703002/1
6 years, 3 months ago (2014-09-23 04:43:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 53f496cd66fed9666274280f15a27ff2e726c58e
6 years, 3 months ago (2014-09-23 04:51:48 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 04:52:18 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d1916b21bb418f3d35b4efcba4853eefaf10f01
Cr-Commit-Position: refs/heads/master@{#296142}

Powered by Google App Engine
This is Rietveld 408576698