Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: athena/content/app_activity.cc

Issue 591693002: Creating PNG images from web content to be used by OverviewMode navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed and using ImageSkia again Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/content/app_activity.cc
diff --git a/athena/content/app_activity.cc b/athena/content/app_activity.cc
index da5f929847a701d836818d0eb14e652632e23148..de0a9da38980e43eb86c970814e02eef569649d5 100644
--- a/athena/content/app_activity.cc
+++ b/athena/content/app_activity.cc
@@ -29,9 +29,11 @@ AppActivity::AppActivity(extensions::AppWindow* app_window,
Observe(app_window->web_contents());
}
-scoped_ptr<ContentProxy> AppActivity::GetContentProxy(aura::Window* window) {
+scoped_ptr<ContentProxy> AppActivity::GetContentProxy() {
+ // Note: After this call, the content is still valid because the contents
+ // destruction will destroy this |AppActivity| object.
if (content_proxy_.get())
- content_proxy_->Reparent(window);
+ content_proxy_->OnPreContentDestroyed();
return content_proxy_.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698