Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: athena/content/app_activity.cc

Issue 591693002: Creating PNG images from web content to be used by OverviewMode navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/content/app_activity.cc
diff --git a/athena/content/app_activity.cc b/athena/content/app_activity.cc
index 6ce1fc29eb21d39705b49c1d68de482401c4c30c..52ef3e02170ded596b17453d886277f58fc2b2e1 100644
--- a/athena/content/app_activity.cc
+++ b/athena/content/app_activity.cc
@@ -25,9 +25,9 @@ AppActivity::AppActivity(const std::string& app_id)
app_activity_registry_(NULL) {
}
-scoped_ptr<ContentProxy> AppActivity::GetContentProxy(aura::Window* window) {
+scoped_ptr<ContentProxy> AppActivity::GetContentProxy() {
if (content_proxy_.get())
- content_proxy_->Reparent(window);
+ content_proxy_->ContentGetsDestroyed();
oshima 2014/09/22 16:10:28 At this point, is AppAcitivyt's content supposed t
Mr4D (OOO till 08-26) 2014/09/23 19:07:33 No, not yet. This object will be destroyed because
return content_proxy_.Pass();
}
@@ -142,10 +142,10 @@ views::View* AppActivity::GetContentsView() {
return web_view_;
}
-gfx::ImageSkia AppActivity::GetOverviewModeImage() {
+scoped_ptr<gfx::Image> AppActivity::GetOverviewModeImage() {
if (content_proxy_.get())
return content_proxy_->GetContentImage();
- return gfx::ImageSkia();
+ return scoped_ptr<gfx::Image> (new gfx::Image());
}
void AppActivity::PrepareContentsForOverview() {

Powered by Google App Engine
This is Rietveld 408576698