Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 591683002: [NaCl SDK Docs] Fix many issues with the doc generator. (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 1 month ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK Docs] Fix many issues with the doc generator. * It was broken after the git switch (it used SVN internally) * Generate Pepper indexes to c-api-{channel} instead of pepper_{channel}/c This relies on using Doxygen 1.7.6.1, which was installed by default on Lucid. Doxygen 1.8 does not work, and maybe never will. You can set the DOXYGEN environment variable to point to a good version of doxygen. No trybots because it is a documentation generation only change. I tested locally to ensure this wouldn't break stuff. BUG=none TEST=local NOTRY=true R=sbc@chromium.org Committed: https://crrev.com/7fba1592940d3fd68fc46600b19b9af104a9c1c0 Cr-Commit-Position: refs/heads/master@{#302127}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : . #

Patch Set 5 : remove doxygen 1.8 stuff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -48 lines) Patch
M native_client_sdk/src/doc/doxygen/generate_docs.py View 1 2 3 4 6 chunks +57 lines, -17 lines 0 comments Download
M native_client_sdk/src/doc/doxygen/rst_index.py View 9 chunks +43 lines, -25 lines 0 comments Download
M native_client_sdk/src/doc/sitemap.rst View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years, 3 months ago (2014-09-19 23:21:54 UTC) #2
Sam Clegg
lgtm https://codereview.chromium.org/591683002/diff/40001/native_client_sdk/src/doc/Makefile File native_client_sdk/src/doc/Makefile (right): https://codereview.chromium.org/591683002/diff/40001/native_client_sdk/src/doc/Makefile#newcode54 native_client_sdk/src/doc/Makefile:54: doxygen/generate_docs.py $(CHROMESITE_BUILDDIR) -v Do we always want this? ...
6 years, 3 months ago (2014-09-20 00:02:36 UTC) #3
binji
https://codereview.chromium.org/591683002/diff/40001/native_client_sdk/src/doc/Makefile File native_client_sdk/src/doc/Makefile (right): https://codereview.chromium.org/591683002/diff/40001/native_client_sdk/src/doc/Makefile#newcode54 native_client_sdk/src/doc/Makefile:54: doxygen/generate_docs.py $(CHROMESITE_BUILDDIR) -v On 2014/09/20 00:02:36, Sam Clegg wrote: ...
6 years, 3 months ago (2014-09-22 17:54:02 UTC) #4
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7fba1592940d3fd68fc46600b19b9af104a9c1c0 Cr-Commit-Position: refs/heads/master@{#302127}
6 years, 1 month ago (2014-10-30 19:21:27 UTC) #5
binji
6 years, 1 month ago (2014-10-30 19:21:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:70001) manually as
7fba1592940d3fd68fc46600b19b9af104a9c1c0.

Powered by Google App Engine
This is Rietveld 408576698