Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 591633002: Replace most uses of ViewManagerInitService with client lib ViewManager::Embed() to offer the same … (Closed)

Created:
6 years, 3 months ago by Ben Goodger (Google)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace most uses of ViewManagerInitService with client lib ViewManager::Embed() to offer the same API exposed via View::Embed() R=sky@chromium.org BUG=none Committed: https://crrev.com/4ca5434de578a41cb86535cfd78cf2ce6659cd24 Cr-Commit-Position: refs/heads/master@{#296087}

Patch Set 1 #

Patch Set 2 : , #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 3

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -88 lines) Patch
M mojo/examples/aura_demo/aura_demo.cc View 7 chunks +20 lines, -21 lines 0 comments Download
M mojo/examples/aura_demo/view_manager_init.cc View 1 2 3 4 5 1 chunk +8 lines, -17 lines 0 comments Download
M mojo/examples/demo_launcher/demo_launcher.cc View 1 2 3 4 5 1 chunk +8 lines, -20 lines 0 comments Download
M mojo/examples/wm_flow/BUILD.gn View 1 2 3 4 6 3 chunks +6 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/app/app.cc View 1 2 3 4 5 4 chunks +5 lines, -12 lines 0 comments Download
M mojo/examples/wm_flow/embedded/embedded.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/wm_flow/init/init.cc View 1 2 3 4 5 2 chunks +5 lines, -12 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
A mojo/services/public/cpp/view_manager/lib/view_manager_context.cc View 1 2 3 4 5 6 7 1 chunk +55 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
A mojo/services/public/cpp/view_manager/view_manager_context.h View 1 2 3 4 5 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ben Goodger (Google)
6 years, 3 months ago (2014-09-22 22:05:16 UTC) #1
sky
LGTM https://codereview.chromium.org/591633002/diff/120001/mojo/examples/wm_flow/BUILD.gn File mojo/examples/wm_flow/BUILD.gn (right): https://codereview.chromium.org/591633002/diff/120001/mojo/examples/wm_flow/BUILD.gn#newcode19 mojo/examples/wm_flow/BUILD.gn:19: # GYP version: mojo/mojo_examples.gypi:mojo_wm_flow_wm Don't you need to ...
6 years, 3 months ago (2014-09-22 22:20:00 UTC) #2
Ben Goodger (Google)
https://codereview.chromium.org/591633002/diff/120001/mojo/examples/wm_flow/BUILD.gn File mojo/examples/wm_flow/BUILD.gn (right): https://codereview.chromium.org/591633002/diff/120001/mojo/examples/wm_flow/BUILD.gn#newcode19 mojo/examples/wm_flow/BUILD.gn:19: # GYP version: mojo/mojo_examples.gypi:mojo_wm_flow_wm On 2014/09/22 22:20:00, sky wrote: ...
6 years, 3 months ago (2014-09-22 22:26:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591633002/140001
6 years, 3 months ago (2014-09-22 22:39:37 UTC) #7
commit-bot: I haz the power
Committed patchset #8 (id:140001) as ef5082762f6aa6939c801de67a66479a1bc0c133
6 years, 3 months ago (2014-09-22 23:23:05 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 23:23:37 UTC) #9
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/4ca5434de578a41cb86535cfd78cf2ce6659cd24
Cr-Commit-Position: refs/heads/master@{#296087}

Powered by Google App Engine
This is Rietveld 408576698