Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 591563002: Try #3 to fix the android layout tests crash in run-webkit-tests. (Closed)

Created:
6 years, 3 months ago by Dirk Pranke
Modified:
6 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Try #3 to fix the android layout tests crash in run-webkit-tests. This patch forcibly reencodes to ASCII at a different layer, matching where we're actually seeing the stack trace. This seems like an overly broad solution, but may at least get us past the crash so I can see where things might really be failing. This change also backs out the change in r182282, since it didn't seem to help anything. TBR=peter@chromium.org BUG=386343 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182358

Patch Set 1 #

Patch Set 2 : s/encode/decode again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
6 years, 3 months ago (2014-09-19 18:42:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591563002/1
6 years, 3 months ago (2014-09-19 18:43:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591563002/20001
6 years, 3 months ago (2014-09-19 20:58:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182358
6 years, 3 months ago (2014-09-19 22:48:17 UTC) #6
caseq
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/590983002/ by caseq@chromium.org. ...
6 years, 3 months ago (2014-09-22 06:32:01 UTC) #7
Dirk Pranke
6 years, 3 months ago (2014-09-22 16:33:45 UTC) #8
Message was sent while issue was closed.
On 2014/09/22 06:32:01, caseq wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/590983002/ by mailto:caseq@chromium.org.
> 
> The reason for reverting is: Reverting, since this broke mac bots:
> 
> UnicodeEncodeError raised: 'ascii' codec can't encode characters in position
> 11332-11333: ordinal not in range(128).

lgtm, thanks! It didn't fix android either ... I guess I thought I had already
reverted it :(.

Powered by Google App Engine
This is Rietveld 408576698