Issue 59153008: Minor adjustment to WebVTT tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59153008: Minor adjustment to WebVTT tests (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, feature-media-reviews_chromium.org, nessy, vcarbune.chromium, philipj_slow

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Minor adjustment to WebVTT tests Do a trivial adjustment to the tc029-timings-whitespace test to make it robust against the spec. change that disallows --> in cue text. Fix test opera/interfaces/TextTrackCue/vertical.html to it possible to pass it (the expected result is still FAIL), by adding a linebreak. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161931

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -38 lines)			Patch
M	LayoutTests/media/track/captions-webvtt/tc029-timings-whitespace.vtt	View	1 chunk	+13 lines, -13 lines	0 comments	Download
M	LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/media/track/track-webvtt-tc029-timings-whitespace.html	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	LayoutTests/media/track/track-webvtt-tc029-timings-whitespace-expected.txt	View	1 chunk	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/59153008/1

7 years, 1 month ago (2013-11-11 12:57:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/59153008/1

7 years, 1 month ago (2013-11-13 14:26:53 UTC) #4

Message was sent while issue was closed.

Change committed as 161931

Expand Messages | Collapse Messages