gin/runner.cc - Issue 59153005: Begin implementing V8 bindings for Mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/runner.cc

Issue 59153005: Begin implementing V8 bindings for Mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix skipped comment Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/runner.cc

diff --git a/gin/runner.cc b/gin/runner.cc

index cf9839951f5381a6f6fcb0d186fbf437c7e2cee2..ec701b7e5a320ced9cf577a8d2bfaf867ebb7629 100644

--- a/gin/runner.cc

+++ b/gin/runner.cc

@@ -44,7 +44,7 @@ void Runner::Run(Handle<Script> script) {

}

v8::Handle<v8::Function> Runner::GetMain() {

- Handle<Value> property = global()->Get(StringToV8(isolate_, "main"));

+ Handle<Value> property = global()->Get(StringToSymbol(isolate_, "main"));

if (property.IsEmpty())

return v8::Handle<v8::Function>();

Handle<Function> main;