Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: gin/converter.cc

Issue 59153005: Begin implementing V8 bindings for Mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moar copyright Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/converter.cc
diff --git a/gin/converter.cc b/gin/converter.cc
index 6b30985069ed270c36350339adc3e9cec99c3338..0e654ec2f6864f98a35a0a1a960dbbb349763c8a 100644
--- a/gin/converter.cc
+++ b/gin/converter.cc
@@ -49,6 +49,28 @@ bool Converter<uint32_t>::FromV8(Handle<Value> val, uint32_t* out) {
return true;
}
+Handle<Value> Converter<int64_t>::ToV8(Isolate* isolate, int64_t val) {
+ return Number::New(isolate, static_cast<double>(val)).As<Value>();
+}
+
+bool Converter<int64_t>::FromV8(Handle<Value> val, int64_t* out) {
+ if (!val->IsNumber())
+ return false;
+ *out = val->IntegerValue();
Aaron Boodman 2013/11/11 19:01:08 I was surprised to see that IntegerValue() returns
abarth-chromium 2013/11/11 20:17:42 Will do.
+ return true;
+}
+
+Handle<Value> Converter<uint64_t>::ToV8(Isolate* isolate, uint64_t val) {
+ return Number::New(isolate, static_cast<double>(val)).As<Value>();
+}
+
+bool Converter<uint64_t>::FromV8(Handle<Value> val, uint64_t* out) {
+ if (!val->IsNumber())
+ return false;
+ *out = static_cast<uint64_t>(val->IntegerValue());
+ return true;
+}
+
Handle<Value> Converter<double>::ToV8(Isolate* isolate, double val) {
return Number::New(isolate, val).As<Value>();
}
@@ -87,7 +109,8 @@ bool Converter<Handle<Function> >::FromV8(Handle<Value> val,
return true;
}
-Handle<Value> Converter<Handle<Object> >::ToV8(Handle<Object> val) {
+Handle<Value> Converter<Handle<Object> >::ToV8(v8::Isolate* isolate,
+ Handle<Object> val) {
return val.As<Value>();
}

Powered by Google App Engine
This is Rietveld 408576698