gin/runner.h - Issue 59153005: Begin implementing V8 bindings for Mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gin/runner.h

Issue 59153005: Begin implementing V8 bindings for Mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moar copyright Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef GIN_RUNNER_H_	5 #ifndef GIN_RUNNER_H_

6 #define GIN_RUNNER_H_	6 #define GIN_RUNNER_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

	9 #include "base/compiler_specific.h"
	Aaron Boodman 2013/11/11 19:01:08 Unnecessary include? Unnecessary include? abarth-chromium 2013/11/11 20:17:42 No, I'm cheating a bit. The files that include th Show quoted text On 2013/11/11 19:01:08, Aaron Boodman wrote: > Unnecessary include? No, I'm cheating a bit. The files that include this header need to see OVERRIDE when subclassing RunnerDelegate, but I didn't want to add base to their DEPS file. Maybe the solution is to whitelist basictypes.h and compiler_specific.h in mojo/public/bindings/js/DEPS
9 #include "v8/include/v8.h"	10 #include "v8/include/v8.h"

10	11

11 namespace gin {	12 namespace gin {

12	13

13 class Runner;	14 class Runner;

14	15

15 class RunnerDelegate {	16 class RunnerDelegate {

16 public:	17 public:

17 // Returns the object that is passed to the script's \|main\| function.	18 // Returns the object that is passed to the script's \|main\| function.

18 virtual v8::Handle<v8::Object> CreateRootObject(Runner* runner) = 0;	19 virtual v8::Handle<v8::Object> CreateRootObject(Runner* runner) = 0;

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 RunnerDelegate* delegate_;	59 RunnerDelegate* delegate_;

59 v8::Isolate* isolate_;	60 v8::Isolate* isolate_;

60 v8::Persistent<v8::Context> context_;	61 v8::Persistent<v8::Context> context_;

61	62

62 DISALLOW_COPY_AND_ASSIGN(Runner);	63 DISALLOW_COPY_AND_ASSIGN(Runner);

63 };	64 };

64	65

65 } // namespace gin	66 } // namespace gin

66	67

67 #endif // GIN_RUNNER_H_	68 #endif // GIN_RUNNER_H_

OLD	NEW

« gin/per_isolate_data.cc ('K') | « gin/per_isolate_data.cc ('k') | gin/test/gtest.h » ('j') | mojo/public/bindings/js/core.cc » ('J')