Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 591503003: Allow out-of-process iframes to paint in --site-per-process. (Closed)

Created:
6 years, 3 months ago by Charlie Reis
Modified:
6 years, 3 months ago
Reviewers:
nasko
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, kenrb, alexmos, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow out-of-process iframes to paint in --site-per-process. This is a quick hack to make the initializeChildFrame message go through RenderFrameProxy rather than RenderFrameImpl, since the RenderFrameHost is deleted before it can receive the message. We can clean up the hack by moving initializeChildFrame to WebRemoteFrameClient and removing WebFrame::setIsRemote. BUG=416102, 407160 TEST=Simple OOPIF paints in --site-per-process. Committed: https://crrev.com/67c253e78c2bc1aa3f6f4123b4b3ccfbcea7068c Cr-Commit-Position: refs/heads/master@{#295813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/renderer/render_frame_impl.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Charlie Reis
Nasko: Here's the hack I mentioned to get OOPIFs painting again, by sending initializeChildFrame via ...
6 years, 3 months ago (2014-09-19 19:24:03 UTC) #2
nasko
LGTM
6 years, 3 months ago (2014-09-19 21:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591503003/1
6 years, 3 months ago (2014-09-19 21:17:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591503003/1
6 years, 3 months ago (2014-09-19 21:17:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11534)
6 years, 3 months ago (2014-09-19 22:20:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591503003/1
6 years, 3 months ago (2014-09-19 22:33:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591503003/1
6 years, 3 months ago (2014-09-19 22:33:36 UTC) #11
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-19 23:18:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591503003/1
6 years, 3 months ago (2014-09-19 23:38:26 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as 918acbe63dbc5f0ab379080947810d4254343781
6 years, 3 months ago (2014-09-19 23:39:41 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 23:41:03 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67c253e78c2bc1aa3f6f4123b4b3ccfbcea7068c
Cr-Commit-Position: refs/heads/master@{#295813}

Powered by Google App Engine
This is Rietveld 408576698