chrome/browser/DEPS - Issue 591483002: Only send C2F ping for a search through homepage.

Side by Side Diff: chrome/browser/DEPS

Issue 591483002: Only send C2F ping for a search through homepage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix a bug. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+apps",	2 "+apps",

3 "+ash",	3 "+ash",

4 "+athena/content/public",	4 "+athena/content/public",

5 "+chrome/app",	5 "+chrome/app",

6 "+chrome/grit", # For generated headers	6 "+chrome/grit", # For generated headers

7 "+chrome/installer",	7 "+chrome/installer",

8 "+chrome_elf/blacklist",	8 "+chrome_elf/blacklist",

9 "+chrome_elf/chrome_elf_constants.h",	9 "+chrome_elf/chrome_elf_constants.h",

10 "+chrome_elf/create_file",	10 "+chrome_elf/create_file",

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
72 "+components/translate/content/common",	72 "+components/translate/content/common",

73 "+components/translate/core/browser",	73 "+components/translate/core/browser",

74 "+components/translate/core/common",	74 "+components/translate/core/common",

75 "+components/url_matcher",	75 "+components/url_matcher",

76 "+components/user_manager",	76 "+components/user_manager",

77 "+components/user_prefs",	77 "+components/user_prefs",

78 "+components/web_modal",	78 "+components/web_modal",

79 "+components/web_cache/browser",	79 "+components/web_cache/browser",

80 "+components/webdata/common",	80 "+components/webdata/common",

81 "+content/public/browser",	81 "+content/public/browser",

82 "+content/test/net",	82 "+content/test",
	sky 2014/10/10 17:45:49 Seems to me we should only be depending on content Seems to me we should only be depending on content/test/public. yao 2014/10/10 18:08:00 you mean content/test/net? We need content::Test Show quoted text On 2014/10/10 17:45:49, sky wrote: > Seems to me we should only be depending on content/test/public. you mean content/test/net? We need content::TestRenderFrameHost to simulate a navigation. Are you aware of another way of achieving this with the correct dependency?
83 "+courgette",	83 "+courgette",

84 "+device/bluetooth",	84 "+device/bluetooth",

85 "+device/core",	85 "+device/core",

86 "+device/hid",	86 "+device/hid",

87 "+device/usb",	87 "+device/usb",

88 "+device/media_transfer_protocol",	88 "+device/media_transfer_protocol",

89 "+extensions/browser",	89 "+extensions/browser",

90 "+extensions/common",	90 "+extensions/common",

91 "+extensions/grit",	91 "+extensions/grit",

92 "+extensions/test",	92 "+extensions/test",

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
159 "+third_party/WebKit/public/web/WebCache.h",	159 "+third_party/WebKit/public/web/WebCache.h",

160 "+third_party/WebKit/public/web/WebContextMenuData.h",	160 "+third_party/WebKit/public/web/WebContextMenuData.h",

161 "+third_party/WebKit/public/web/WebFindOptions.h",	161 "+third_party/WebKit/public/web/WebFindOptions.h",

162 "+third_party/WebKit/public/web/WebInputEvent.h",	162 "+third_party/WebKit/public/web/WebInputEvent.h",

163 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",	163 "+third_party/WebKit/public/web/WebMediaPlayerAction.h",

164 "+third_party/WebKit/public/web/WebPageVisibilityState.h",	164 "+third_party/WebKit/public/web/WebPageVisibilityState.h",

165 "+third_party/WebKit/public/web/WebPluginAction.h",	165 "+third_party/WebKit/public/web/WebPluginAction.h",

166 "+third_party/WebKit/public/web/WebTextDirection.h",	166 "+third_party/WebKit/public/web/WebTextDirection.h",

167 "+third_party/WebKit/public/web/WebWindowFeatures.h",	167 "+third_party/WebKit/public/web/WebWindowFeatures.h",

168 ]	168 ]

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/rlz/rlz.cc » ('j') | no next file with comments »