chrome/browser/extensions/api/messaging/native_message_port.h - Issue 591463003: Remote Assistance on Chrome OS Part III - NativeMessageHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_port.h

Issue 591463003: Remote Assistance on Chrome OS Part III - NativeMessageHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_messaging

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc ('K') | « chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc ('k') | chrome/browser/extensions/api/messaging/native_message_port.cc » ('j') | chrome/browser/extensions/api/messaging/native_message_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_port.h

diff --git a/chrome/browser/extensions/api/messaging/native_message_port.h b/chrome/browser/extensions/api/messaging/native_message_port.h

index f94db96a8ad107afaa09850d9a6ad7da5d960714..d0f291415b519c37af6761611f65c931caa238b1 100644

--- a/chrome/browser/extensions/api/messaging/native_message_port.h

+++ b/chrome/browser/extensions/api/messaging/native_message_port.h

@@ -13,14 +13,14 @@ class NativeMessageProcessHost;

// A port that manages communication with a native application.

class NativeMessagePort : public MessageService::MessagePort {

public:

- // Takes ownership of |native_process|.

- explicit NativeMessagePort(NativeMessageProcessHost* native_process);

+ // Takes ownership of |native_message_host|.

Sergey Ulanov 2014/09/22 23:42:59 Please use scoped_ptr<> to pass ownership and remo

kelvinp 2014/09/23 20:16:42 Done.

+ explicit NativeMessagePort(NativeMessageHost* native_message_host);

virtual ~NativeMessagePort();

virtual void DispatchOnMessage(const Message& message,

int target_port_id) OVERRIDE;

private:

- NativeMessageProcessHost* native_process_;

+ NativeMessageHost* native_message_host_;

};

} // namespace extensions