 Chromium Code Reviews
 Chromium Code Reviews Issue 591463003:
  Remote Assistance on Chrome OS Part III - NativeMessageHost  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@native_messaging
    
  
    Issue 591463003:
  Remote Assistance on Chrome OS Part III - NativeMessageHost  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@native_messaging| Index: chrome/browser/extensions/api/messaging/message_service.h | 
| diff --git a/chrome/browser/extensions/api/messaging/message_service.h b/chrome/browser/extensions/api/messaging/message_service.h | 
| index a8ca3231bb8db84c18a7c7c36bfde9d5bc2bcaca..62126a118f96d7c3da899e1e54251a5d8c474c30 100644 | 
| --- a/chrome/browser/extensions/api/messaging/message_service.h | 
| +++ b/chrome/browser/extensions/api/messaging/message_service.h | 
| @@ -14,9 +14,9 @@ | 
| #include "base/memory/scoped_ptr.h" | 
| #include "base/memory/weak_ptr.h" | 
| #include "chrome/browser/extensions/api/messaging/message_property_provider.h" | 
| -#include "chrome/browser/extensions/api/messaging/native_message_process_host.h" | 
| #include "content/public/browser/notification_observer.h" | 
| #include "content/public/browser/notification_registrar.h" | 
| +#include "extensions/browser/api/messaging/native_message_host.h" | 
| #include "extensions/browser/browser_context_keyed_api_factory.h" | 
| #include "extensions/common/api/messaging/message.h" | 
| @@ -61,7 +61,7 @@ class LazyBackgroundTaskQueue; | 
| // RenderProcessHost or a RenderViewHost. | 
| class MessageService : public BrowserContextKeyedAPI, | 
| public content::NotificationObserver, | 
| - public NativeMessageProcessHost::Client { | 
| + public NativeMessageHost::Client { | 
| public: | 
| // A messaging channel. Note that the opening port can be the same as the | 
| // receiver, if an extension background page wants to talk to its tab (for | 
| @@ -153,10 +153,9 @@ class MessageService : public BrowserContextKeyedAPI, | 
| // port if the channel isn't pending. | 
| void PostMessage(int port_id, const Message& message); | 
| - // NativeMessageProcessHost::Client | 
| - virtual void PostMessageFromNativeProcess( | 
| - int port_id, | 
| - const std::string& message) OVERRIDE; | 
| + // NativeMessageHost::Client implementation. | 
| + virtual void PostMessageFromNative(int port_id, | 
| 
Sergey Ulanov
2014/09/22 23:42:58
I think it's better to keep the old name.
 
kelvinp
2014/09/23 20:16:41
Renamed to PostMessageFromNative.
 | 
| + const std::string& message) OVERRIDE; | 
| private: | 
| friend class MockMessageService; |