Remote Assistance on Chrome OS Part III - NativeMessageHost

chrome/browser/extensions/api/messaging/native_message_process_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_MESSAGING_NATIVE_MESSAGE_PROCESS_HOST_H_
 #define CHROME_BROWSER_EXTENSIONS_API_MESSAGING_NATIVE_MESSAGE_PROCESS_HOST_H_
 
 #include <queue>
 #include <string>
 
 #include "base/files/file.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/process/process.h"
 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
+#include "extensions/browser/api/messaging/native_message_host.h"
 #include "ui/gfx/native_widget_types.h"
 
 class PrefService;

[Sergey Ulanov, 2014/09/22 23:42:59]

this can be removed

[kelvinp, 2014/09/23 20:16:42]

Done.

 
 namespace net {
 
 class DrainableIOBuffer;
 class FileStream;
 class IOBuffer;
 class IOBufferWithSize;
 
 }  // namespace net
 
 namespace extensions {
 
 // Manages the native side of a connection between an extension and a native
 // process.
 //
 // This class must only be created, called, and deleted on the IO thread.
 // Public methods typically accept callbacks which will be invoked on the UI
 // thread.
-class NativeMessageProcessHost
+class NativeMessageProcessHost :
 #if defined(OS_POSIX)
-    : public base::MessageLoopForIO::Watcher
+    public base::MessageLoopForIO::Watcher,
 #endif  // !defined(OS_POSIX)
-{
+    public NativeMessageHost {
  public:
-  // Interface for the object that receives messages from the native process.
-  class Client {
-   public:
-    virtual ~Client() {}
-    // Called on the UI thread.
-    virtual void PostMessageFromNativeProcess(int port_id,
-                                              const std::string& message) = 0;
-    virtual void CloseChannel(int port_id,
-                              const std::string& error_message) = 0;
-  };
-
-  // Result returned from IsHostAllowed().
-  enum PolicyPermission {
-    DISALLOW,           // The host is not allowed.
-    ALLOW_SYSTEM_ONLY,  // Allowed only when installed on system level.
-    ALLOW_ALL,          // Allowed when installed on system or user level.
-  };
+  typedef NativeMessageHost::Client Client;
 
   virtual ~NativeMessageProcessHost();
 
-  // Returns policy permissions for the host with the specified name.
-  static PolicyPermission IsHostAllowed(const PrefService* pref_service,
-                                        const std::string& native_host_name);
-
-  static scoped_ptr<NativeMessageProcessHost> Create(
-      gfx::NativeView native_view,
+  // Create using specified |launcher|. Used in tests.
+  static scoped_ptr<NativeMessageHost> CreateWithLauncher(
       base::WeakPtr<Client> weak_client_ui,
       const std::string& source_extension_id,
       const std::string& native_host_name,
-      int destination_port,
-      bool allow_user_level);
-
-  // Create using specified |launcher|. Used in tests.
-  static scoped_ptr<NativeMessageProcessHost> CreateWithLauncher(
-      base::WeakPtr<Client> weak_client_ui,
-      const std::string& source_extension_id,
-      const std::string& native_host_name,
       int destination_port,
       scoped_ptr<NativeProcessLauncher> launcher);
 
   // Send a message with the specified payload.

[Sergey Ulanov, 2014/09/22 23:42:59]

Replace this comment with // NativeMessageHost implementation.

[kelvinp, 2014/09/23 20:16:42]

Done.

-  void Send(const std::string& json);
+  virtual void Send(const std::string& json) OVERRIDE;
 
 #if defined(OS_POSIX)
   // MessageLoopForIO::Watcher interface
   virtual void OnFileCanReadWithoutBlocking(int fd) OVERRIDE;
   virtual void OnFileCanWriteWithoutBlocking(int fd) OVERRIDE;
 #endif  // !defined(OS_POSIX)
 
   // Try and read a single message from |read_file_|. This should only be called
   // in unittests when you know there is data in the file.
   void ReadNowForTesting();
@@ skipping 80 matching lines @@
 
   // Set to true when a write is pending.
   bool write_pending_;
 
   DISALLOW_COPY_AND_ASSIGN(NativeMessageProcessHost);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_MESSAGING_NATIVE_MESSAGE_PROCESS_HOST_H_