Remote Assistance on Chrome OS Part III - NativeMessageHost

remoting/host/it2me/it2me_native_messaging_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
-#include "extensions/browser/api/messaging/native_messaging_channel.h"
+#include "extensions/browser/api/messaging/native_message_host.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/it2me/it2me_host.h"
 
 namespace base {
 class DictionaryValue;
+class Value;
 }  // namespace base
 
 namespace remoting {
 
 // Implementation of the native messaging host process.
-class It2MeNativeMessagingHost
-    : public It2MeHost::Observer,
-      public extensions::NativeMessagingChannel::EventHandler {
+class It2MeNativeMessagingHost : public It2MeHost::Observer,
+                                 public extensions::NativeMessageHost {
  public:
-  It2MeNativeMessagingHost(
-      scoped_refptr<AutoThreadTaskRunner> task_runner,
-      scoped_ptr<extensions::NativeMessagingChannel> channel,
-      scoped_ptr<It2MeHostFactory> factory);
+  It2MeNativeMessagingHost(scoped_refptr<AutoThreadTaskRunner> task_runner,
+                           scoped_ptr<It2MeHostFactory> factory);
   virtual ~It2MeNativeMessagingHost();
 
-  void Start(const base::Closure& quit_closure);
-
-  // extensions::NativeMessagingChannel::EventHandler implementation.
-  virtual void OnMessage(scoped_ptr<base::Value> message) OVERRIDE;
-  virtual void OnDisconnect() OVERRIDE;
+  // extensions::NativeMessageHost implementation.
+  // Called when a message is received from the client.

[Sergey Ulanov, 2014/09/27 00:24:10]

This comment wouldn't be necessary if you rename Send() to OnMessage().

[kelvinp, 2014/09/29 22:59:40]

Done.

+  virtual void Send(const std::string& json) OVERRIDE;
+  virtual void set_client(base::WeakPtr<Client> client) OVERRIDE;
 
   // It2MeHost::Observer implementation.
   virtual void OnClientAuthenticated(const std::string& client_username)
       OVERRIDE;
   virtual void OnStoreAccessCode(const std::string& access_code,
                                  base::TimeDelta access_code_lifetime) OVERRIDE;
   virtual void OnNatPolicyChanged(bool nat_traversal_enabled) OVERRIDE;
   virtual void OnStateChanged(It2MeHostState state) OVERRIDE;
 
   static std::string HostStateToString(It2MeHostState host_state);
 
  private:
   // These "Process.." methods handle specific request types. The |response|
   // dictionary is pre-filled by ProcessMessage() with the parts of the
   // response already known ("id" and "type" fields).
+  void OnMessageFromClient(scoped_ptr<base::Value> message);
   void ProcessHello(const base::DictionaryValue& message,
                     scoped_ptr<base::DictionaryValue> response) const;
   void ProcessConnect(const base::DictionaryValue& message,
                       scoped_ptr<base::DictionaryValue> response);
   void ProcessDisconnect(const base::DictionaryValue& message,
                          scoped_ptr<base::DictionaryValue> response);
   void SendErrorAndExit(scoped_ptr<base::DictionaryValue> response,
                         const std::string& description) const;
-
-  base::Closure quit_closure_;
+  void SendMessageToClient(scoped_ptr<base::DictionaryValue> message) const;
 
   scoped_refptr<AutoThreadTaskRunner> task_runner() const;
 
-  scoped_ptr<extensions::NativeMessagingChannel> channel_;
+  base::WeakPtr<Client> client_;
   scoped_ptr<It2MeHostFactory> factory_;
   scoped_ptr<ChromotingHostContext> host_context_;
   scoped_refptr<It2MeHost> it2me_host_;
 
   // Cached, read-only copies of |it2me_host_| session state.
   It2MeHostState state_;
   std::string access_code_;
   base::TimeDelta access_code_lifetime_;
   std::string client_username_;
 
   // IT2Me Talk server configuration used by |it2me_host_| to connect.
   XmppSignalStrategy::XmppServerConfig xmpp_server_config_;
 
   // Chromoting Bot JID used by |it2me_host_| to register the host.
   std::string directory_bot_jid_;
 
   base::WeakPtr<It2MeNativeMessagingHost> weak_ptr_;
   base::WeakPtrFactory<It2MeNativeMessagingHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(It2MeNativeMessagingHost);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_