Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 591443002: Componentize permission_request_id.* (Closed)

Created:
6 years, 3 months ago by lucinka.brozkova
Modified:
6 years, 3 months ago
Reviewers:
James Hawkins, blundell
CC:
chromium-reviews, extensions-reviews_chromium.org, zea+watch_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, Michael van Ouwerkerk, chromium-apps-reviews_chromium.org, markusheintz_, wjia+watch_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Componentize permission_request_id.* Files moved and includes adjusted. BUG=387072 Committed: https://crrev.com/7a631f8c65ffe60521296709da2922376ac25e4e Cr-Commit-Position: refs/heads/master@{#296263}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -108 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_bubble_request_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_queue_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/content_settings/permission_request_id.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/content_settings/permission_request_id.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/geolocation/geolocation_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_infobar_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/services/gcm/push_messaging_service_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M components/content_settings.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/content_settings/core/common/permission_request_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/content_settings/core/common/permission_request_id.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
lucinka.brozkova
Hi blundell and jhawkins, Can you please do an OWNERS review? blundell@ components/* jhawkins@ chrome/* ...
6 years, 3 months ago (2014-09-19 19:17:57 UTC) #2
James Hawkins
lgtm
6 years, 3 months ago (2014-09-19 22:32:09 UTC) #3
blundell
//components lgtm
6 years, 3 months ago (2014-09-22 12:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591443002/1
6 years, 3 months ago (2014-09-22 17:42:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/49338) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/6152) android_clang_dbg_recipe ...
6 years, 3 months ago (2014-09-22 17:49:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591443002/20001
6 years, 3 months ago (2014-09-23 20:45:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fc22410029cbfcc033a46157018baf222d43891f
6 years, 3 months ago (2014-09-23 21:47:46 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 21:49:18 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a631f8c65ffe60521296709da2922376ac25e4e
Cr-Commit-Position: refs/heads/master@{#296263}

Powered by Google App Engine
This is Rietveld 408576698