Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 59143005: Refactoring markers.html to use async path for spellcheck (Closed)

Created:
7 years, 1 month ago by grzegorz
Modified:
7 years, 1 month ago
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Refactoring markers.html to use async path for spellcheck Rewrite spelling/markers.html to use asynchronous spellchecking. Additionally, remove unnecessary code. BUG=295722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -55 lines) Patch
M LayoutTests/editing/spelling/markers.html View 2 chunks +58 lines, -42 lines 0 comments Download
M LayoutTests/editing/spelling/markers-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
grzegorz
7 years, 1 month ago (2013-11-05 12:52:12 UTC) #1
tony
LGTM
7 years, 1 month ago (2013-11-05 17:39:16 UTC) #2
groby-ooo-7-16
lgtm
7 years, 1 month ago (2013-11-06 01:51:40 UTC) #3
grzegorz
Hi, may I ask you to commit this CL and my pending spellchecking patches? https://codereview.chromium.org/57823002/ ...
7 years, 1 month ago (2013-11-06 07:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/59143005/1
7 years, 1 month ago (2013-11-06 07:55:35 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 09:00:40 UTC) #6
Message was sent while issue was closed.
Change committed as 161435

Powered by Google App Engine
This is Rietveld 408576698