Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: Source/bindings/scripts/unstable/v8_utilities.py

Issue 59143004: IDL compiler: Rename [ActivityLogging=Access*] => [ActivityLogging=*] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/unstable/v8_methods.py ('k') | Source/bindings/tests/idls/TestActiveDOMObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_utilities.py
diff --git a/Source/bindings/scripts/unstable/v8_utilities.py b/Source/bindings/scripts/unstable/v8_utilities.py
index fb80cbc5a11ba5a9b74d2187ea30a2ce40ea3551..8857e0d32e8c8fb399dd92653035bd9ec3714235 100644
--- a/Source/bindings/scripts/unstable/v8_utilities.py
+++ b/Source/bindings/scripts/unstable/v8_utilities.py
@@ -114,18 +114,17 @@ def activity_logging_world_list(member, access_type=None):
if 'ActivityLogging' not in member.extended_attributes:
return set()
activity_logging = member.extended_attributes['ActivityLogging']
- # [ActivityLogging=Access*] means log for all access, otherwise check that
- # value agrees with specified access_type.
- has_logging = (activity_logging.startswith('Access') or
+ # [ActivityLogging=For*] (no prefix, starts with the worlds suffix) means
+ # "log for all use (method)/access (attribute)", otherwise check that value
+ # agrees with specified access_type (Getter/Setter).
+ has_logging = (activity_logging.startswith('For') or
(access_type and activity_logging.startswith(access_type)))
if not has_logging:
return set()
includes.add('bindings/v8/V8DOMActivityLogger.h')
if activity_logging.endswith('ForIsolatedWorlds'):
return set([''])
- if activity_logging.endswith('ForAllWorlds'):
- return set(['', 'ForMainWorld'])
- raise 'Unrecognized [ActivityLogging] value: "%s"' % activity_logging
Nils Barth (inactive) 2013/11/05 10:56:13 This check and exception are unneeded, b/c already
+ return set(['', 'ForMainWorld']) # endswith('ForAllWorlds')
# [CallWith]
« no previous file with comments | « Source/bindings/scripts/unstable/v8_methods.py ('k') | Source/bindings/tests/idls/TestActiveDOMObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698