Source/bindings/scripts/code_generator_v8.pm - Issue 59143004: IDL compiler: Rename [ActivityLogging=Access*] => [ActivityLogging=*]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 59143004: IDL compiler: Rename [ActivityLogging=Access*] => [ActivityLogging=*] (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.pm

diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm

index fb8817d80684a69f8be5df3b11e83002af40dffe..81297bfc92fdacbe79effbac705c45af192f3144 100644

--- a/Source/bindings/scripts/code_generator_v8.pm

+++ b/Source/bindings/scripts/code_generator_v8.pm

@@ -1105,7 +1105,7 @@ sub HasActivityLogging

if (!$attrExt->{"ActivityLogging"}) {

return 0;

}

- my $logAllAccess = ($attrExt->{"ActivityLogging"} =~ /^Access/);

+ my $logAllAccess = ($attrExt->{"ActivityLogging"} =~ /^For/); # No prefix, starts with For*Worlds suffix

my $logGetter = ($attrExt->{"ActivityLogging"} =~ /^Getter/);

my $logSetter = ($attrExt->{"ActivityLogging"} =~ /^Setter/);

my $logOnlyIsolatedWorlds = ($attrExt->{"ActivityLogging"} =~ /ForIsolatedWorlds$/);