Issue 59143004: IDL compiler: Rename [ActivityLogging=Access*] => [ActivityLogging=*]

Issue 59143004: IDL compiler: Rename [ActivityLogging=Access] => [ActivityLogging=] (Closed)

Created:
7 years, 1 month ago by Nils Barth (inactive)

Modified:
7 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, philipj_slow, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Michael van Ouwerkerk, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: Rename [ActivityLogging=Access*] => [ActivityLogging=*] 'Access' is confusing and unnecessary in the context of methods; default to logging all call (methods) or access (attributes), and only require specification if specifically Getter/Setter. Docs: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-ActivityLogging-m-a- BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161411

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -51 lines)			Patch
M	Source/bindings/scripts/IDLAttributes.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/code_generator_v8.pm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/unstable/v8_methods.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/unstable/v8_utilities.py	View	1 chunk	+5 lines, -6 lines	1 comment	Download
M	Source/bindings/tests/idls/TestActiveDOMObject.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/idls/TestObject.idl	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Document.idl	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/dom/Element.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Node.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/frame/Location.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/frame/Window.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLCanvasElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLDocument.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/storage/Storage.idl	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequest.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/geolocation/Geolocation.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/notifications/NotificationCenter.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webdatabase/WindowWebDatabase.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

https://codereview.chromium.org/59143004/diff/1/Source/bindings/scripts/unstable/v8_utilities.py File Source/bindings/scripts/unstable/v8_utilities.py (left): https://codereview.chromium.org/59143004/diff/1/Source/bindings/scripts/unstable/v8_utilities.py#oldcode128 Source/bindings/scripts/unstable/v8_utilities.py:128: raise 'Unrecognized [ActivityLogging] value: "%s"' % activity_logging This check ...

7 years, 1 month ago (2013-11-05 10:56:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/59143004/1

7 years, 1 month ago (2013-11-06 01:03:11 UTC) #3

Message was sent while issue was closed.

Change committed as 161411

Expand Messages | Collapse Messages