Source/core/frame/Settings.in - Issue 591413003: Add a mechanism for users to opt-out of CSP & XSS violations reports.

Side by Side Diff: Source/core/frame/Settings.in

Issue 591413003: Add a mechanism for users to opt-out of CSP & XSS violations reports. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | Source/core/frame/csp/ContentSecurityPolicy.cpp » ('j') | Source/core/frame/csp/ContentSecurityPolicy.cpp » ('J')

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 279 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
290 # has pointerType coarse and fine).	290 # has pointerType coarse and fine).

291 availablePointerTypes type=int, initial=PointerTypeNone, invalidate=MediaQuery	291 availablePointerTypes type=int, initial=PointerTypeNone, invalidate=MediaQuery

292 availableHoverTypes type=int, initial=HoverTypeNone, invalidate=MediaQuery	292 availableHoverTypes type=int, initial=HoverTypeNone, invalidate=MediaQuery

293	293

294 # These values specify properties of the user's primary pointing device only.	294 # These values specify properties of the user's primary pointing device only.

295 primaryPointerType type=PointerType, initial=PointerTypeNone, invalidate=MediaQu ery	295 primaryPointerType type=PointerType, initial=PointerTypeNone, invalidate=MediaQu ery

296 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery	296 primaryHoverType type=HoverType, initial=HoverTypeNone, invalidate=MediaQuery

297	297

298 accessibilityEnabled initial=false	298 accessibilityEnabled initial=false

299 inlineTextBoxAccessibilityEnabled initial=false	299 inlineTextBoxAccessibilityEnabled initial=false

	300

	301 CSPViolationReportsUploadOptOut initial=false
	Mike West 2014/09/24 09:07:55 I'd suggest changing this to 'CSPViolationReportsE I'd suggest changing this to 'CSPViolationReportsEnabled initial=true'. There's no hard and fast rule, as you'll probably notice from skimming through the settings in this document, but I prefer settings in this form, rather than dealing with a situation where "true" means "don't do this thing". Mayur Kankanwadi 2014/09/25 08:40:37 Done. Show quoted text On 2014/09/24 09:07:55, Mike West wrote: > I'd suggest changing this to 'CSPViolationReportsEnabled initial=true'. There's > no hard and fast rule, as you'll probably notice from skimming through the > settings in this document, but I prefer settings in this form, rather than > dealing with a situation where "true" means "don't do this thing". Done. Mayur Kankanwadi 2014/09/25 08:40:37 Done. Show quoted text On 2014/09/24 09:07:55, Mike West wrote: > I'd suggest changing this to 'CSPViolationReportsEnabled initial=true'. There's > no hard and fast rule, as you'll probably notice from skimming through the > settings in this document, but I prefer settings in this form, rather than > dealing with a situation where "true" means "don't do this thing". Done.
	302 xssViolationReportsUploadOptOut initial=false

	303

OLD	NEW