Use base::StringPairs where appropriate from src/google_apis

Use base::StringPairs where appropriate from src/google_apis

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/0fd0f5870365ec408ebbdcd22ff9ad99b8b7be3d
Cr-Commit-Position: refs/heads/master@{#296888}

[Anand Ratn (left samsung), 2014-09-23 11:46:41]

anand.ratn@samsung.com changed reviewers:
+ ben@chromium.org, darin@chromium.org

[Anand Ratn (left samsung), 2014-09-23 11:46:41]

darin@chromium.org: Please review changes in src/google_apis module

ben@chromium.org: Please review changes in src/google_apis module

[Ben Goodger (Google), 2014-09-24 17:27:35]

Please look at local owners file in this subdir. Darin & I are owners of
src/ which in practice means we should only be consulted about changes to
the toplevel directory structure.

-Ben

On Tue, Sep 23, 2014 at 4:46 AM, <anand.ratn@samsung.com> wrote:

> Reviewers: darin, Ben Goodger (Google),
>
> Message:
> darin@chromium.org: Please review changes in src/google_apis module
>
> ben@chromium.org: Please review changes in src/google_apis module
>
>
> Description:
> Use base::StringPairs where appropriate from src/google_apis
>
> Becuase base/strings/string_split.h defines:
> typedef std::vector<std::pair<std::string, std::string> > StringPairs;
>
> BUG=412250
>
> Please review this at https://codereview.chromium.org/591413002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+2, -2 lines):
>   M google_apis/gaia/gaia_auth_fetcher.cc
>
>
> Index: google_apis/gaia/gaia_auth_fetcher.cc
> diff --git a/google_apis/gaia/gaia_auth_fetcher.cc
> b/google_apis/gaia/gaia_auth_fetcher.cc
> index b0046d5eb30094023cb3354db2e3553919226a52..
> 55a60627565cc64c5521a4aa1f89e896dd82035d 100644
> --- a/google_apis/gaia/gaia_auth_fetcher.cc
> +++ b/google_apis/gaia/gaia_auth_fetcher.cc
> @@ -867,10 +867,10 @@ void GaiaAuthFetcher::OnGetUserInfoFetched(
>      const net::URLRequestStatus& status,
>      int response_code) {
>    if (status.is_success() && response_code == net::HTTP_OK) {
> -    std::vector<std::pair<std::string, std::string> > tokens;
> +    base::StringPairs tokens;
>      UserInfoMap matches;
>      base::SplitStringIntoKeyValuePairs(data, '=', '\n', &tokens);
> -    std::vector<std::pair<std::string, std::string> >::iterator i;
> +    base::StringPairs::iterator i;
>      for (i = tokens.begin(); i != tokens.end(); ++i) {
>        matches[i->first] = i->second;
>      }
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Anand Ratn (left samsung), 2014-09-25 04:34:18]

anand.ratn@samsung.com changed reviewers:
+ rogerta@chromium.org
- ben@chromium.org, darin@chromium.org

[Anand Ratn (left samsung), 2014-09-25 04:35:59]

On 2014/09/24 17:27:35, Ben Goodger (Google) wrote:
> Please look at local owners file in this subdir. Darin & I are owners of
> src/ which in practice means we should only be consulted about changes to
> the toplevel directory structure.
> 
> -Ben
> 
> On Tue, Sep 23, 2014 at 4:46 AM, <mailto:anand.ratn@samsung.com> wrote:
> 
> > Reviewers: darin, Ben Goodger (Google),
> >
> > Message:
> > mailto:darin@chromium.org: Please review changes in src/google_apis module
> >
> > mailto:ben@chromium.org: Please review changes in src/google_apis module
> >
> >
> > Description:
> > Use base::StringPairs where appropriate from src/google_apis
> >
> > Becuase base/strings/string_split.h defines:
> > typedef std::vector<std::pair<std::string, std::string> > StringPairs;
> >
> > BUG=412250
> >
> > Please review this at https://codereview.chromium.org/591413002/
> >
> > SVN Base: https://chromium.googlesource.com/chromium/src.git@master
> >
> > Affected files (+2, -2 lines):
> >   M google_apis/gaia/gaia_auth_fetcher.cc
> >
> >
> > Index: google_apis/gaia/gaia_auth_fetcher.cc
> > diff --git a/google_apis/gaia/gaia_auth_fetcher.cc
> > b/google_apis/gaia/gaia_auth_fetcher.cc
> > index b0046d5eb30094023cb3354db2e3553919226a52..
> > 55a60627565cc64c5521a4aa1f89e896dd82035d 100644
> > --- a/google_apis/gaia/gaia_auth_fetcher.cc
> > +++ b/google_apis/gaia/gaia_auth_fetcher.cc
> > @@ -867,10 +867,10 @@ void GaiaAuthFetcher::OnGetUserInfoFetched(
> >      const net::URLRequestStatus& status,
> >      int response_code) {
> >    if (status.is_success() && response_code == net::HTTP_OK) {
> > -    std::vector<std::pair<std::string, std::string> > tokens;
> > +    base::StringPairs tokens;
> >      UserInfoMap matches;
> >      base::SplitStringIntoKeyValuePairs(data, '=', '\n', &tokens);
> > -    std::vector<std::pair<std::string, std::string> >::iterator i;
> > +    base::StringPairs::iterator i;
> >      for (i = tokens.begin(); i != tokens.end(); ++i) {
> >        matches[i->first] = i->second;
> >      }
> >
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Thank you Ben. I have added the corresponding folder owner for this patch.
Roger: PTAL

[Roger Tawa OOO till Jul 10th, 2014-09-25 14:05:33]

lgtm

[Anand Ratn (left samsung), 2014-09-26 04:02:36]

The CQ bit was checked by anand.ratn@samsung.com

[Anand Ratn (left samsung), 2014-09-26 04:03:18]

On 2014/09/25 14:05:33, Roger Tawa wrote:
> lgtm

Thanks for the review Roger.

[commit-bot: I haz the power, 2014-09-26 04:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/591413002/1

[commit-bot: I haz the power, 2014-09-26 05:17:49]

Committed patchset #1 (id:1) as 845b2adab8997492358a0211a9495b869dc7539b

[commit-bot: I haz the power, 2014-09-26 05:18:34]

Patchset 1 (id:??) landed as
https://crrev.com/0fd0f5870365ec408ebbdcd22ff9ad99b8b7be3d
Cr-Commit-Position: refs/heads/master@{#296888}