Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 591383003: [turbofan] ARM64 support for inverted logical ops (Closed)

Created:
6 years, 3 months ago by m.m.capewell
Modified:
6 years, 3 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM64 support for inverted logical ops Select ARM64 inverted rhs instructions (bic, orn, eon) for cases where the rhs input is inverted (using e/xor), and add some tests for this. Also, rename xor to eor in the ARM64 backend. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24188

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete stray newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -23 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +90 lines, -16 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 3 chunks +163 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
m.m.capewell
6 years, 3 months ago (2014-09-23 15:00:37 UTC) #2
Benedikt Meurer
LGTM with nit, very nice! https://codereview.chromium.org/591383003/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/591383003/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode1278 src/compiler/arm64/instruction-selector-arm64-unittest.cc:1278: Nit: extra new line. ...
6 years, 3 months ago (2014-09-24 06:36:07 UTC) #3
m.m.capewell
https://codereview.chromium.org/591383003/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc File src/compiler/arm64/instruction-selector-arm64-unittest.cc (right): https://codereview.chromium.org/591383003/diff/1/src/compiler/arm64/instruction-selector-arm64-unittest.cc#newcode1278 src/compiler/arm64/instruction-selector-arm64-unittest.cc:1278: On 2014/09/24 06:36:07, Benedikt Meurer wrote: > Nit: extra ...
6 years, 3 months ago (2014-09-24 10:37:07 UTC) #4
m.m.capewell
6 years, 3 months ago (2014-09-24 14:55:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 24188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698