Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 591383002: [check Style] java files in android part have 100 char limit per line (Closed)

Created:
6 years, 3 months ago by riju_
Modified:
6 years, 2 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, riju_, darin-cc_chromium.org, jam, timvolodine, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[StyleNits] java files in android part have 100 char limit per line Committed: https://crrev.com/ff80a90193ee92e556806e31af43e10e54a5d94f Cr-Commit-Position: refs/heads/master@{#296982}

Patch Set 1 #

Patch Set 2 : Name 'R' must match pattern '^[a-z][a-zA-Z0-9]*$' #

Total comments: 2

Patch Set 3 : Keep capital R as it is, since it represents matrix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java View 2 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/DeviceSensorsTest.java View 9 chunks +11 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
riju_
StyleNits only. 1 remnant of https://codereview.chromium.org/292693004 and some additional style nits.
6 years, 3 months ago (2014-09-23 14:21:46 UTC) #3
timvolodine
https://codereview.chromium.org/591383002/diff/40001/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java File content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java (right): https://codereview.chromium.org/591383002/diff/40001/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java#newcode273 content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:273: * @param r please leave capital R as is, ...
6 years, 2 months ago (2014-09-25 21:35:06 UTC) #4
riju_
PTAL. https://codereview.chromium.org/591383002/diff/40001/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java File content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java (right): https://codereview.chromium.org/591383002/diff/40001/content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java#newcode273 content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:273: * @param r On 2014/09/25 21:35:05, timvolodine wrote: ...
6 years, 2 months ago (2014-09-26 04:33:26 UTC) #5
timvolodine
lgtm
6 years, 2 months ago (2014-09-26 12:58:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/591383002/60001
6 years, 2 months ago (2014-09-26 17:38:50 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 8ee83ab0c42a5bc387b670d4147d8cea06fb4f25
6 years, 2 months ago (2014-09-26 18:27:23 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 18:27:57 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ff80a90193ee92e556806e31af43e10e54a5d94f
Cr-Commit-Position: refs/heads/master@{#296982}

Powered by Google App Engine
This is Rietveld 408576698