Issue 591373003: Move test for reduction of Math.imul to unittest.

Issue 591373003: Move test for reduction of Math.imul to unittest. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Move test for reduction of Math.imul to unittest. R=bmeurer@chromium.org TEST=compiler-unittests/JSBuiltinReducerTest.MathImul Committed: https://code.google.com/p/v8/source/detail?r=24144

Patch Set 2 : Addressed comments by Benedikt. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -30 lines)			Patch
M	src/compiler/compiler.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/graph-unittest.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/graph-unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	src/compiler/js-builtin-reducer-unittest.cc	View	1	1 chunk	+89 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View		2 chunks	+1 line, -28 lines	0 comments	Download
M	testing/gtest-support.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

LGTM with nit. https://codereview.chromium.org/591373003/diff/1/src/compiler/js-builtin-reducer-unittest.cc File src/compiler/js-builtin-reducer-unittest.cc (right): https://codereview.chromium.org/591373003/diff/1/src/compiler/js-builtin-reducer-unittest.cc#newcode47 src/compiler/js-builtin-reducer-unittest.cc:47: static Type* kNumberTypes[] = { Nit: ...

6 years, 3 months ago (2014-09-23 10:25:58 UTC) #2

Michael Starzinger

Addressed comments. Landing. https://codereview.chromium.org/591373003/diff/1/src/compiler/js-builtin-reducer-unittest.cc File src/compiler/js-builtin-reducer-unittest.cc (right): https://codereview.chromium.org/591373003/diff/1/src/compiler/js-builtin-reducer-unittest.cc#newcode47 src/compiler/js-builtin-reducer-unittest.cc:47: static Type* kNumberTypes[] = { On ...

6 years, 3 months ago (2014-09-23 10:31:30 UTC) #3

Michael Starzinger

6 years, 3 months ago (2014-09-23 11:27:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24144 (presubmit successful).

Expand Messages | Collapse Messages