brettw
2014/09/25 22:11:32
I usually like source and deps on separate lines e
I usually like source and deps on separate lines even if there is only one since
it makes it easier to add stuff. But this is fine for now, and I won't be too
sad if we decide to change the rule to make the autoformatting easier.
scottmg
2014/09/25 23:03:11
You mean specifically just for source and deps, no
On 2014/09/25 22:11:32, brettw wrote:
> I usually like source and deps on separate lines even if there is only one
since
> it makes it easier to add stuff. But this is fine for now, and I won't be too
> sad if we decide to change the rule to make the autoformatting easier.
You mean specifically just for source and deps, not all lists? Right now it
doesn't know what the lhs of the list is, but we could certainly have a pass
that walks the tree and forces things the way we like them.
brettw
2014/09/25 23:06:58
Yeah, in the style guide I listed these as separat
Yeah, in the style guide I listed these as separate cases to always use the
multiline format when assigning (but not +=. But with an autoformatter, I'm not
necessarily wedded to this, and it could be a bad idea.
Issue 591373002: gn: start of format command
(Closed)
Created 6 years, 3 months ago by scottmg
Modified 6 years, 2 months ago
Reviewers: brettw
Base URL: https://chromium.googlesource.com/chromium/src.git@gn-more-comment-stuff
Comments: 19